[release/6.0] Fix Logging Source Generator to handle file-scoped namespaces (#57894) #59100
Conversation
Handle namespace not being emitted when file-scoped namespaces are used for a log class. Relates to dotnet#57880.
|
Tagging subscribers to this area: @maryamariyan Issue DetailsHandle namespace not being emitted when file-scoped cherry pick of PR #57894 /cc @danmoseley for M2 approval
|
|
As noted offline please take the time to do the right fix (you mentioned possibly making more changes) this will also need a template filled out. |
|
@danmoseley updated with template in description |
maryamariyan
added
the
Servicing-consider
danmoseley
changed the title
danmoseley
added
Servicing-approved
|
@maryamariyan there are real build breaks here. could you please take a look? |
|
Right these changes are because @eerhardt made changes later in his source generator refactoring but didn't include those when ported to release/6.0. Order in main was M > E, order in release is E > M. @maryamariyan mentioned she was going to port the part of @eerhardt's change that was missed. |
ghost
locked as resolved and limited conversation to collaborators
PR Content
Cherry pick of PR #57894
Relates to #57880.
The feedback expressed in #57894 (comment) improves the fix in main branch but we have as-is should be sufficient for release branch.
Customer Impact
Logging Source Generator fails to compile due to CS8795 error with file-scoped namespaces.
The fix will handle usages of file-scoped namespaces for logging method.
Testing
Included in PR
Risk
Low, since file-scoped namespace is a C#10 feature (check here) and the logging source generator is a 6.0 feature and this fix is concerned with these two new features used in combination.
/cc @danmoseley for M2 approval