[release/6.0] Ignore the DuplicateExtension status from macOS 12. #58889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS 12 introduces a new X.509 chain status, DuplicateExtension. As we do not report this in Windows and nor do we have a flag to map it to, we ignore it from macOS.
ghost
added
the
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks |
bartonjs
approved these changes
Sep 9, 2021
Member
|
Approved. Fixes hindrance to OS upgrade. Change is very localized and consistent with changes in the past. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58834 to release/6.0
/cc @bartonjs @vcsjones
Customer Impact
Customers running on macOS 12 with atypical X.509 certificates may get exceptions out of X509Chain.Build.
dotnet/runtime developers and CI will fail running existing tests on macOS 12.
Testing
Caught by an existing test during OS scouting.
Risk
Low (caught by an existing test, following an existing pattern).