Skip to content

Use separate VNs for DBL2INT_OVF helpers #58868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Use separate VNs for DBL2INT_OVF helpers #58868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d09c00f
Use separate VNs for DBL2INT_OVF helpers
EgorBo Sep 9, 2021
d530f57
Update Runtime_58832.cs
EgorBo Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/coreclr/jit/valuenum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9825,25 +9825,25 @@ VNFunc Compiler::fgValueNumberJitHelperMethodVNFunc(CorInfoHelpFunc helpFunc)
vnf = VNF_Dbl2Int;
break;
case CORINFO_HELP_DBL2INT_OVF:
vnf = VNF_Dbl2Int;
vnf = VNF_Dbl2IntOvf;
break;
case CORINFO_HELP_DBL2LNG:
vnf = VNF_Dbl2Lng;
break;
case CORINFO_HELP_DBL2LNG_OVF:
vnf = VNF_Dbl2Lng;
vnf = VNF_Dbl2LngOvf;
break;
case CORINFO_HELP_DBL2UINT:
vnf = VNF_Dbl2UInt;
break;
case CORINFO_HELP_DBL2UINT_OVF:
vnf = VNF_Dbl2UInt;
vnf = VNF_Dbl2UIntOvf;
break;
case CORINFO_HELP_DBL2ULNG:
vnf = VNF_Dbl2ULng;
break;
case CORINFO_HELP_DBL2ULNG_OVF:
vnf = VNF_Dbl2ULng;
vnf = VNF_Dbl2ULngOvf;
break;
case CORINFO_HELP_FLTREM:
vnf = VNFunc(GT_MOD);
Expand Down
4 changes: 4 additions & 0 deletions src/coreclr/jit/valuenumfuncs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ ValueNumFuncDef(Dbl2Int, 1, false, false, false)
ValueNumFuncDef(Dbl2UInt, 1, false, false, false)
ValueNumFuncDef(Dbl2Lng, 1, false, false, false)
ValueNumFuncDef(Dbl2ULng, 1, false, false, false)
ValueNumFuncDef(Dbl2IntOvf, 1, false, false, false)
ValueNumFuncDef(Dbl2UIntOvf, 1, false, false, false)
ValueNumFuncDef(Dbl2LngOvf, 1, false, false, false)
ValueNumFuncDef(Dbl2ULngOvf, 1, false, false, false)
ValueNumFuncDef(FltRound, 1, false, false, false)
ValueNumFuncDef(DblRound, 1, false, false, false)

Expand Down
30 changes: 30 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_58832/Runtime_58832.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;

public class Runtime_58832
{
public static int Main()
{
try
{
Test(double.MaxValue);
}
catch (OverflowException)
{
return 100;
}
return 101;
}

[MethodImpl(MethodImplOptions.NoInlining)]
private static void Test(double x)
{
try { Console.WriteLine(checked((ulong)x)); } catch { }

if ((ulong)x == checked((ulong)x))
Console.WriteLine("Should not be invoked");
}
}
10 changes: 10 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_58832/Runtime_58832.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<DebugType>None</DebugType>
<Optimize>True</Optimize>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
</Project>