[release/6.0] Fix Windows 8 detection in Pbkdf2 #58823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58736 to release/6.0
Customer Impact
Customers using the
Rfc2898DeriveBytes.Pbkdf2on Windows 8, Windows 8.1, Windows Server 2012 and Windows Server 2012R2 will get suboptimal performance due to mis-detection of available OS features. The performance of this API is important in web scenarios for hashing passwords.The code was originally looking for version "8.0" of Windows, however Windows 8.0 reports itself as Windows version 6.2.
Testing
The improved functionality had existed tests and was being exercised in Windows 10. This is just making that functionality available to Windows 8.
Risk
Low. The functionality was already being exercised in Windows 10 and the code change is a small adjustment to a Windows versions detection.