Skip to content

PosixSignalRegistrationTests.Unix: validate signal pal mapping #58711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2021
Merged

PosixSignalRegistrationTests.Unix: validate signal pal mapping #58711

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
056ee77
PosixSignalRegistrationTests.Unix: validate signal pal mapping
tmds Sep 6, 2021
7b45670
Use InvariantCulture for pid ToString
tmds Sep 6, 2021
56fe2f2
Invoke kill through shell.
tmds Sep 6, 2021
7f58c9d
Remove InvariantCulture
tmds Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...InteropServices/tests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// The .NET Foundation licenses this file to you under the MIT license.

using Xunit;
using System.Diagnostics;
using System.Globalization;
using System.Threading;
using System.Runtime.InteropServices;
using System.Runtime.CompilerServices;
Expand Down Expand Up @@ -57,7 +59,16 @@ public void SignalHandlerCalledForKnownSignals(PosixSignal s)
semaphore.Release();
});

kill(signal);
// Use 'kill' command with signal name to validate the signal pal mapping.
string sigArg = signalStr.StartsWith("SIG") ? signalStr.Substring(3) : signalStr;
using var process = Process.Start(new ProcessStartInfo
{
FileName = "/bin/sh", // Use a shell because not all platforms include a 'kill' executable.
ArgumentList = { "-c", $"kill -s {sigArg} {Environment.ProcessId.ToString()}" }
Copy link
Member

@stephentoub stephentoub Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
ArgumentList = { "-c", $"kill -s {sigArg} {Environment.ProcessId.ToString()}" }
ArgumentList = { "-c", $"kill -s {sigArg} {Environment.ProcessId}" }

});
process.WaitForExit();
Assert.Equal(0, process.ExitCode);

bool entered = semaphore.Wait(SuccessTimeout);
Assert.True(entered);
}, s.ToString()).Dispose();
Expand Down