Conditionally pack symbols based on keepNativeSymbols #58565
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsRelated to #58455 (comment) Source build runs with FYI, I will port this to main as well.
|
| <IsPackable>true</IsPackable> | ||
| <AllowedOutputExtensionsInSymbolsPackageBuildOutputFolder>$(SymbolsSuffix)</AllowedOutputExtensionsInSymbolsPackageBuildOutputFolder> | ||
| <TargetsForTfmSpecificDebugSymbolsInPackage>$(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage</TargetsForTfmSpecificDebugSymbolsInPackage> | ||
| <TargetsForTfmSpecificDebugSymbolsInPackage Condition="'$(keepNativeSymbols)' != 'true'">$(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage</TargetsForTfmSpecificDebugSymbolsInPackage> |
There was a problem hiding this comment.
Is keepNativeSymbols an environment variable? Who sets it? Asking as it looks very strange for an msbuild property.
There was a problem hiding this comment.
It gets set by source build here
<InnerBuildArgs>$(InnerBuildArgs) /p:KeepNativeSymbols=true</InnerBuildArgs>
There was a problem hiding this comment.
Cool. Should we fix the casing then? :)
| <TargetsForTfmSpecificDebugSymbolsInPackage Condition="'$(keepNativeSymbols)' != 'true'">$(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage</TargetsForTfmSpecificDebugSymbolsInPackage> | |
| <TargetsForTfmSpecificDebugSymbolsInPackage Condition="'$(KeepNativeSymbols)' != 'true'">$(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage</TargetsForTfmSpecificDebugSymbolsInPackage> |
There was a problem hiding this comment.
Maybe also add a comment here explaining what this does?
There was a problem hiding this comment.
Fixed casing and added comment.
|
cc @danmoseley, tell-mode infra change for source-build. |
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/runtime/actions/runs/1195310445 |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Related to #58455 (comment)
Source build runs with
keepNativeSymbols=truewhich prevents the symbols from being stripped out and placed into a separate .dbg files. This supports the normal workflows used by distro package maintainers. You can read more background here. This change conditionsTargetsForTfmSpecificDebugSymbolsInPackageon thekeepNativeSymbols.FYI, I will port this to main as well once this PR gets approval.