Skip to content

[release/6.0] [HTTP/3] Stress disable offending op causing server errors #58541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2021
Merged

[release/6.0] [HTTP/3] Stress disable offending op causing server errors #58541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/libraries/stress/http.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:

- bash: |
cd '$(httpStressProject)'
export HTTPSTRESS_CLIENT_ARGS="$HTTPSTRESS_CLIENT_ARGS -http 3.0"
export HTTPSTRESS_CLIENT_ARGS="$HTTPSTRESS_CLIENT_ARGS -http 3.0 -xops 10"
export HTTPSTRESS_SERVER_ARGS="$HTTPSTRESS_SERVER_ARGS -http 3.0"
docker-compose up --abort-on-container-exit --no-color
displayName: Run HttpStress - HTTP 3.0
Expand Down
6 changes: 0 additions & 6 deletions src/libraries/System.Net.Http/tests/StressTests/HttpStress/ClientOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,12 +508,6 @@ public static (string name, Func<RequestContext, Task> operation)[] Operations =

private static void ValidateStatusCode(HttpResponseMessage m, HttpStatusCode expectedStatus = HttpStatusCode.OK)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]
if (m.StatusCode == HttpStatusCode.InternalServerError)
{
throw new Exception("IGNORE");
}

if (m.StatusCode != expectedStatus)
{
throw new Exception($"Expected status code {expectedStatus}, got {m.StatusCode}");
Expand Down
5 changes: 0 additions & 5 deletions src/libraries/System.Net.Http/tests/StressTests/HttpStress/StressClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,6 @@ async Task RunWorker(int taskNum)
{
_aggregator.RecordCancellation(opIndex, stopwatch.Elapsed);
}
catch (Exception e) when (e.Message == "IGNORE")
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]
// See ClientOperations.ValidateStatusCode
}
catch (Exception e)
{
_aggregator.RecordFailure(e, opIndex, stopwatch.Elapsed, requestContext.IsCancellationRequested, taskNum: taskNum, iteration: i);
Expand Down