Support duplicated type names with src gen #58448
Conversation
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsAddresses #57349 Expected to be ported to 6.0.
|
| return attributes; | ||
| } | ||
|
|
||
| // Copied from: https://github.com/roslyn/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/CompilationExtensions.cs |
There was a problem hiding this comment.
would it make sense to segregate all the borrowed code into its own file ?
There was a problem hiding this comment.
FWIW I believe the logging generator needs to use these methods as well, so we should move to a common location. cc @maryamariyan
There was a problem hiding this comment.
Thanks. The second commit does this.
| byte[] referencedImage; | ||
| using (MemoryStream ms = new MemoryStream()) | ||
| { | ||
| var emitResult = referencedCompilation.Emit(ms); | ||
| if (!emitResult.Success) | ||
| { | ||
| throw new InvalidOperationException(); | ||
| } | ||
| referencedImage = ms.ToArray(); |
There was a problem hiding this comment.
Very minor nit: this could have been a helper method.
There was a problem hiding this comment.
Thanks; left as-is. Note there are other tests that have the same pattern.
|
Would prefer review from @sharwell before merging. |
sharwell
left a comment
sharwell
left a comment
There was a problem hiding this comment.
Assuming this was copied in and the new test fails prior to the code change, this LGTM
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1210809901 |
ghost
locked as resolved and limited conversation to collaborators
5 participants
Addresses #57349
Expected to be ported to 6.0.