A few more regex test #58154
Merged
A few more regex test #58154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions Issue DetailsBorrow a few parser tests from Rust (https://github.com/rust-lang/regex). I'll add some execution tests later, although unfortunately many we already have as they derive from the AT&T tests. Work around #56945 which only seems to affect one of my machines.
|
stephentoub
reviewed
Aug 26, 2021
src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.netfx.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 26, 2021
src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.netcoreapp.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 26, 2021
src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 26, 2021
src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 26, 2021
src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 26, 2021
src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 26, 2021
src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 26, 2021
src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Aug 26, 2021
pgovind
reviewed
Aug 30, 2021
pgovind
approved these changes
Aug 30, 2021
pgovind
left a comment
pgovind
left a comment
There was a problem hiding this comment.
Nothing more to add after Stephen's comments. LGTM!
Member
Author
|
@steveisok I have seen this MacCatalyst was canceled on other PR's. I'm merging because the possibility of these test changes having an issue specific to MacCatalyst is ~zero. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrow a few parser tests from Rust (https://github.com/rust-lang/regex). I'll add some execution tests later, although unfortunately many we already have as they derive from the AT&T tests.
Work around #56945 which only seems to affect one of my machines.