Prevent AV in processinfo2 while suspended on Mono. #58099
Conversation
dotnet#55379 only fixed CoreCLR. This commit makes similar fix in Mono as well, making sure src/tests/tracing/eventpipe/diagnosticport runtime test pass on Mono.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/CC @josalem |
|
@steveisok shouldn't we run runtime test suite on OSX as part of CI? This test, src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs, started to fail on all Mono platforms when #55379 was merged and that test is not included on the exclusion list, so it should run as part of CI and been caught before merge. |
|
Looks like the tests are not fully run since the test run is not setting COMPlus_TieredCompilation=0 causing tests to be skipped. |
|
This probably also need to apply to Mono, |
|
Enabling tests marked as JitOptimizationSensitive, #58106, should at least fail on the test fixed by this PR, but could fail on more since those test have also been skipped in previous runs. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1169442484 |
ghost
locked as resolved and limited conversation to collaborators
2 participants
#55379 only fixed CoreCLR. This commit makes similar fix in Mono as well, making sure
src/tests/tracing/eventpipe/diagnosticport runtime test pass on Mono.