Skip to content

[wasm][debugger] Fixing DebuggerDisplayAttribute when using utf16 characters #58084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2021
Merged

[wasm][debugger] Fixing DebuggerDisplayAttribute when using utf16 characters #58084

merged 1 commit into from
Aug 25, 2021

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Aug 25, 2021

Fixing viewing DebuggerDisplayAttribute content with utf16 characters.
Using the same method used on debugger-libs to read string from buffer: https://github.com/mono/debugger-libs/blob/03850bfd42eb17d6425f03ee03114f9dc471db6c/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs#L865

Fixes #58046

@thaystg thaystg requested review from lewing and radical August 25, 2021 00:01
@thaystg thaystg requested a review from marek-safar as a code owner August 25, 2021 00:01
@ghost ghost added the area-Debugger-mono label Aug 25, 2021
@ghost
Copy link

ghost commented Aug 25, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixing viewing DebuggerDisplayAttribute content with utf16 characters.
Using the same method used on debugger-libs to read string from buffer: https://github.com/mono/debugger-libs/blob/03850bfd42eb17d6425f03ee03114f9dc471db6c/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs#L865

Fixes #58046

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono
Milestone: -

@thaystg thaystg removed the request for review from marek-safar August 25, 2021 00:01
@radical radical added the arch-wasm WebAssembly architecture label Aug 25, 2021
@ghost
Copy link

ghost commented Aug 25, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixing viewing DebuggerDisplayAttribute content with utf16 characters.
Using the same method used on debugger-libs to read string from buffer: https://github.com/mono/debugger-libs/blob/03850bfd42eb17d6425f03ee03114f9dc471db6c/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs#L865

Fixes #58046

Author: thaystg
Assignees: -
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@thaystg
Copy link
Member Author

thaystg commented Aug 25, 2021

/backport to release/6.0-rc1

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2021

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1164698641

@github-actions github-actions bot mentioned this pull request Aug 25, 2021
Merged
@lewing lewing merged commit d40fbf4 into dotnet:main Aug 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@lewing lewing lewing approved these changes

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: DebuggerDisplay in Blazor has problems with special characters (umlauts)

3 participants

@thaystg @radical @lewing