-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[mono] Support RuntimeType.MakeGenericType with non-RuntimeType elements #58014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
uweigand
commented
Aug 24, 2021
- Fixes [mono] RuntimeType.MakeGenericType with non-RuntimeType elements not supported #58013
|
Do we need to add test? |
|
runtime (Libraries Test Run release mono Linux arm64 Debug) hit #57941 |
|
@uweigand - can we get a test added for the change ? |
|
Added test case. The test fails on Mono without this patch and passes with it. In any case it passes with CoreCLR. If there is a more straightforward way to create a non-RuntimeType type, I'd appreciate any suggestions ... |
I think Or include |
Thanks for the pointers! While investigating those, I found |
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1174964346 |