Fix enum memory code paths #57981
Merged
Fix enum memory code paths #57981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon, @krwq |
mikem8361
approved these changes
Aug 24, 2021
Contributor
mikem8361
left a comment
mikem8361
left a comment
There was a problem hiding this comment.
Looks good. I built/ran your changes under the SOS tests on Windows and Linux and everything passes.
We will need to backport to rc2 (release/6.0).
Contributor
|
@cshung is there anything else needed before merging this PR? |
Contributor
Author
|
I am working on testing it under |
mikem8361
approved these changes
Aug 24, 2021
Contributor
mikem8361
left a comment
mikem8361
left a comment
There was a problem hiding this comment.
Looks good. Ran the SOS tests again on Windows and Linux.
Contributor
|
/backport release/6.0 |
Contributor
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1164449928 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #57960
This fixes a few things:
dac_gc_heapare no longer guaranteed to be matching the target, in fact, the fields are no longer contiguous, therefore we need to callDacEnumMemoryRegionon individual fields separately.dac_generation.The arguments passed into
DacEnumMemoryRegionshould correspond to the right target addresses.Beyond manual inspection, is there something we can run to make sure this is correct?