[release/6.0] Fix Enum.Parse's parse failure exception to include value in error message #57975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
|
cc: @danmoseley |
Member
|
approved for 6.0 -- significant regression if you're debugging, low risk localized change. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57945 to release/6.0
/cc @stephentoub
Customer Impact
Exception message coming from Enum.Parse isn't as helpful as it previously was (and looks wrong, with
''in the message where there's obviously supposed to be a value).Testing
Added new test for CI
Risk
Minimal change, low risk on an exception path. Primary concern would be if it somehow regressed perf, but I didn't measure any impact locally.