Skip to content

Pack windows implementation assemblies in windowsdesktop transport package #57795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2021
Merged

Pack windows implementation assemblies in windowsdesktop transport package #57795

merged 1 commit into from
Aug 20, 2021

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Aug 20, 2021

Fixes #57791

@ericstj ericstj requested review from Anipik and ViktorHofer August 20, 2021 01:39
@ghost
Copy link

ghost commented Aug 20, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #57791

Author: ericstj
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@ericstj
Copy link
Member Author

ericstj commented Aug 20, 2021

This will need to be ported to RC1 to unblock winforms.

@ericstj
Copy link
Member Author

ericstj commented Aug 20, 2021

/backport to release/6.0-rc1

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2021

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1149127242

RussKie
RussKie approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions github-actions bot mentioned this pull request Aug 20, 2021
Merged
ViktorHofer
ViktorHofer approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to double check that that's the right metadata. Thanks, I completely forgot making sure that the right rid tfm pair gets in.

@ViktorHofer ViktorHofer merged commit 3dba803 into dotnet:main Aug 20, 2021
@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 20, 2021

Did you consider changing the target framework instead to we windows specific?

@ericstj
Copy link
Member Author

ericstj commented Aug 20, 2021

I tried to change the project framework but that required a larger change to the targets that pack this project as they ended up packing as net6.0-windows This change was the smallest that fixed the issue.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@Anipik Anipik Awaiting requested review from Anipik

+1 more reviewer

@RussKie RussKie RussKie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unhandled exception about "System.Drawing.Common is not supported on this platform" occurs when running winforms application

3 participants

@ericstj @ViktorHofer @RussKie