Skip to content

Fix Microsoft.NETCore.Platforms builds on Unix #57739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix Microsoft.NETCore.Platforms builds on Unix #57739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.SDK">
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member

@am11 am11 Aug 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would had made more sense for SDK resolver to keep names case insensitive (i doubt it would break anything since changing just the casing and publishing a different SDK to nuget.org doesn't work anyway), and especially since there are legit SDKs available with capital casing, e.g. Microsoft.NET.SDK.WorkloadAutoImportPropsLocator, Microsoft.NET.SDK.WorkloadManifestTargetsLocator; it's very easy to make this mistake. 😅

Copy link
Member Author

@ViktorHofer ViktorHofer Aug 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed...

<PropertyGroup>
<TargetFrameworks>$(NetCoreAppToolCurrent);net472</TargetFrameworks>
<!-- This project should not build against the live built .NETCoreApp targeting pack as it contributes to the build itself. -->
Expand Down