Remove Net5CompatFileStreamStrategy.
#57735
Conversation
ghost
added
area-System.IO
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsFixes #55196. I leave it here to be merged when seen fit. c.c. @adamsitnik
|
| // - Net5CompatFileStreamStrategy.CompletionSource | ||
| // Async completion/return codes used by | ||
| // SafeFileHandle.OverlappedValueTaskSource | ||
| internal static class TaskSourceCodes |
There was a problem hiding this comment.
This class is unused but I didn't remove it to avoid surprising any new code that might decide to use it in the meantime until the PR is merged.
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
"sight for sore eyes", thank you @teo-tsirpanis !
|
It took me one Google search to understand what you said (thought there was a problem with your eyes and was confused), but I'm glad you liked it. 😊 Removing old code is satisfactory for both the doer and the beholder. |
|
@adamsitnik Our plan was to do this in early 7.0 previews, but after we were sure 6.0 was stabilized and on its path toward GA. If we merge this eagerly, then any changes/fixes to the file stream strategy work might have conflicts between |
|
I plan to merge it after we snap for RC2 (14th of September) |
|
@teo-tsirpanis - can you resolve the conflicts in this PR? |
|
Done @eerhardt. |
teo-tsirpanis
force-pushed
the
net5compatstrategy-remove
branch
from
d5c731f to
cee7adc
Compare
ghost
locked as resolved and limited conversation to collaborators
adamsitnik
added
the
needs-breaking-change-doc-created
|
Breaking change doc issue: dotnet/docs#31465 |
jozkee
removed
the
needs-breaking-change-doc-created
5 participants
Fixes #55196. I leave it here to be merged when seen fit.
c.c. @adamsitnik