Delete code under FEATURE_PREJIT #57693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Aug 18, 2021
am11
reviewed
Aug 19, 2021
| @@ -1256,32 +1250,9 @@ bool DacDbiInterfaceImpl::GetILImageInfoFromNgenPEFile(VMPTR_PEFile vmPEFile, | |||
| DWORD &dwSize, | |||
| IStringHolder* pStrFilename) | |||
| { | |||
| #if !defined(FEATURE_PREJIT) | |||
|
|
|||
| return false; | |||
There was a problem hiding this comment.
This method is now a dead code. Should it be deleted?
There was a problem hiding this comment.
Yes. I wanted to keep this PR to just deleting things under the FEATURE_PREJIT define though, so I didn't do additional cleanup.
There's definitely a bunch of methods that now always return true/false/null or do nothing such that they and their usage can be removed. I'd rather handle those separately from the initial coarse delete of the ifdef-ed code.
am11
reviewed
Aug 19, 2021
| @@ -5796,42 +5742,14 @@ HRESULT DacDbiInterfaceImpl::SetNGENCompilerFlags(DWORD dwFlags) | |||
| { | |||
| DD_ENTER_MAY_THROW; | |||
|
|
|||
| #ifndef FEATURE_PREJIT | |||
| return CORDBG_E_NGEN_NOT_SUPPORTED; | |||
ghost
locked as resolved and limited conversation to collaborators
|
@elinor-fung, should runtime/src/coreclr/inc/clrconfigvalues.h Line 405 in 8ec52d6 runtime/src/coreclr/inc/clrconfigvalues.h Line 800 in 8ec52d6 |
|
Indeed, they should: #75911 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57660
Contributes to #54129 and #53007
cc: @dotnet/crossgen-contrib @AaronRobinsonMSFT @jkoritzinsky @jkotas @agocke