Skip to content

[libraries][iOS][tvOS] Reenable System.Resource.ResourceManager and System.Collections.Immutable tests #56994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 6, 2021

Fixes #36876
Fixes #36893

@mdh1418 mdh1418 requested a review from steveisok August 6, 2021 17:36
@ghost ghost added the area-System.Resources label Aug 6, 2021
@ghost
Copy link

ghost commented Aug 6, 2021

Tagging subscribers to this area: @tarekgh, @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #36876
Fixes #36893

Author: mdh1418
Assignees: -
Labels:

area-System.Resources

Milestone: -

@mdh1418 mdh1418 force-pushed the ios_tvos_reenable_system_resource_resourcemanager_tests branch from c59e0b7 to 1942df4 Compare August 9, 2021 17:37
@mdh1418
Copy link
Member Author

mdh1418 commented Aug 10, 2021

The failures in runtime-staging are unrelated
#57010, a flakey System.Diagnostics.DiagnosticSource.Tests, some System.TypeInitializationException : The type initializer for 'System.Drawing.Printing.PrintingServices' threw an exception.\n---- System.TypeInitializationException : The type initializer for 'System.Drawing.Printing.LibcupsNative' threw an exception.\n-------- System.PlatformNotSupportedException : System.Drawing.Common is not supported on non-Windows platforms. See https://aka.ms/systemdrawingnonwindows for more information., and a few System.NotSupportedException : Support for UTF-7 is disabled. See https://aka.ms/dotnet-warnings/SYSLIB0001 for more information.
Will create an issue targeting net 7.0 to skip the flakes

Checking the results of the build test runs, both System.Resources.Tests.ResourceManagerTests.GetString_FromTestClassWithoutNeutralResources and System.Resources.Tests.ResourceManagerTests.GetString_CultureFallback pass, and System.Collections.Immutable.Tests.ImmutableArrayTest.IStructuralEquatableGetHashCode has no member data, so it is not ran.

@mdh1418 mdh1418 merged commit 4566436 into dotnet:main Aug 10, 2021
@mdh1418 mdh1418 deleted the ios_tvos_reenable_system_resource_resourcemanager_tests branch August 10, 2021 14:21
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

System.Resources.ResourceManager.Tests fails on iOS/tvOS System.Collections tests failing on iOS, tvOS
3 participants