Skip to content

Run just Android Arm64 System.Security.Cryptography.Pkcs.Tests #56861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 6, 2021
Merged

Run just Android Arm64 System.Security.Cryptography.Pkcs.Tests #56861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2112f85
Run just Android Arm64 System.Security.Cryptography.Pkcs.Tests
Aug 4, 2021
7c4ec1d
Revert "Run just Android Arm64 System.Security.Cryptography.Pkcs.Tests"
Aug 4, 2021
2559395
[libraries][Android] Remove System.Security.Cryptography.Pkcs.Tests p…
Aug 4, 2021
294ea15
Skip System.Security.Cryptography.Pkcs on CI for x64 x86 crash
Aug 5, 2021
89564b4
Reduce iteration count for Android due to high memory allocation
Aug 5, 2021
c7f6c10
Revert "Skip System.Security.Cryptography.Pkcs on CI for x64 x86 crash"
Aug 5, 2021
2908617
Add comment to explain change and use inline condition
Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/libraries/System.Security.Cryptography.Pkcs/tests/Pkcs12/Pkcs12InfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,12 @@ public static IEnumerable<object[]> DecodeWithHighPbeIterationsData
{
get
{
yield return new object[] { PbeEncryptionAlgorithm.Aes128Cbc, HashAlgorithmName.SHA256, 700_000 };
yield return new object[] { PbeEncryptionAlgorithm.Aes192Cbc, HashAlgorithmName.SHA256, 700_000 };
yield return new object[] { PbeEncryptionAlgorithm.Aes256Cbc, HashAlgorithmName.SHA256, 700_000 };
yield return new object[] { PbeEncryptionAlgorithm.TripleDes3KeyPkcs12, HashAlgorithmName.SHA1, 600_000 };
// On Android, the tests run out of memory when running DecodeWithHighPbeIterations and causes a crash in CI
// Instead of disabling the whole suite, we opted to reduce the number of iterations to help the tests pass
yield return new object[] { PbeEncryptionAlgorithm.Aes128Cbc, HashAlgorithmName.SHA256, OperatingSystem.IsAndroid() ? 7000 : 700_000 };
yield return new object[] { PbeEncryptionAlgorithm.Aes192Cbc, HashAlgorithmName.SHA256, OperatingSystem.IsAndroid() ? 7000 : 700_000 };
yield return new object[] { PbeEncryptionAlgorithm.Aes256Cbc, HashAlgorithmName.SHA256, OperatingSystem.IsAndroid() ? 7000 : 700_000 };
yield return new object[] { PbeEncryptionAlgorithm.TripleDes3KeyPkcs12, HashAlgorithmName.SHA1, OperatingSystem.IsAndroid() ? 6000 : 600_000 };
}
}

Expand Down
6 changes: 0 additions & 6 deletions src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,10 @@
<!-- Crash https://github.com/dotnet/runtime/issues/55823 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Experimental\tests\System.Runtime.Experimental.Tests.csproj" />

<!-- Crashes on x64 and x86, but not arm64 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Security.Cryptography.Pkcs\tests\System.Security.Cryptography.Pkcs.Tests.csproj" />

<!-- Actual test failures -->
<!-- https://github.com/dotnet/runtime/issues/37088 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime\tests\System.Runtime.Tests.csproj" />

<!-- Runs an fails on arm64 https://github.com/dotnet/runtime/issues/37094 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Security.Cryptography.Pkcs\tests\System.Security.Cryptography.Pkcs.Tests.csproj" />

<!-- https://github.com/dotnet/runtime/issues/50871 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.DependencyInjection\tests\DI.Tests\Microsoft.Extensions.DependencyInjection.Tests.csproj" />

Expand Down