Skip to content

enable Alpn_H3_Success test #56818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2021
Merged

enable Alpn_H3_Success test #56818

merged 3 commits into from
Aug 4, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 4, 2021

I could not reproduce the failure nor I see obvious reason why this would fail.
This may be victim of the deadlock fixed in #56600.

It is curious that the file has tests with the same pattern .... and they are all disabled.
All but one - ServerCertificateCustomValidationCallback_Succeeds added by @ManickaP.
That one is also lacking await on serverTask so we would not know if that task hangs or fails (as long as it does enough work to make client happy)

To move forward, I updated the test with similar pattern and without the SemaphoreSlim.
If it ever fails again, hopeful we would get more visibility.

fixes #56609

@wfurt wfurt added area-System.Net.Http test-enhancement Improvements of test source code labels Aug 4, 2021
@wfurt wfurt requested a review from a team August 4, 2021 05:05
@wfurt wfurt self-assigned this Aug 4, 2021
@ghost
Copy link

ghost commented Aug 4, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

I could not reproduce the failure nor I see obvious reason why this would fail.
This may be victim of the deadlock fixed in #56600.

It is curious that the file has tests with the same pattern .... and they are all disabled.
All but one - ServerCertificateCustomValidationCallback_Succeeds added by @ManickaP.
That one is also lacking await on serverTask so we would not know if that task hangs or fails (as long as it does enough work to make client happy)

To move forward, I updated the test with similar pattern and without the SemaphoreSlim.
If it ever fails again, hopeful we would get more visibility.

fixes #56609

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Http, test enhancement

Milestone: -

@wfurt wfurt merged commit bfee0bb into dotnet:main Aug 4, 2021
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTTP/3] Test Timeout: Alpn_H3_Success
3 participants