Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not reproduce the failure nor I see obvious reason why this would fail.
This may be victim of the deadlock fixed in #56600.
It is curious that the file has tests with the same pattern .... and they are all disabled.
All but one - ServerCertificateCustomValidationCallback_Succeeds added by @ManickaP.
That one is also lacking await on
serverTask
so we would not know if that task hangs or fails (as long as it does enough work to make client happy)To move forward, I updated the test with similar pattern and without the SemaphoreSlim.
If it ever fails again, hopeful we would get more visibility.
fixes #56609