Define timeout for CreateSocket.Ctor_SafeHandle_Listening_Success #56717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #56666. The test uses sync API-s which I didn't want to change so I wrapped the code with
|
MihaZupan
approved these changes
Aug 2, 2021
src/libraries/System.Net.Sockets/tests/FunctionalTests/CreateSocketTests.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| } | ||
| }).WaitAsync(TimeSpan.FromSeconds(30)); |
There was a problem hiding this comment.
Suggested change
| }).WaitAsync(TimeSpan.FromSeconds(30)); | |
| }).WaitAsync(TestSettings.PassingTestTimeout); |
There was a problem hiding this comment.
I was afraid that PassingTestTimeout=10sec might be too strict on slow CI machines, but let's see where it goes :)
There was a problem hiding this comment.
Oh.. I didn't realize it was 10 seconds here since Http tests are using 1 minute
stephentoub
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #56666. The test uses sync API-s which I didn't want to change so I wrapped the code with
Task.Run(...).WaitAsync(...).