Move ILLink.LinkAttributes to shared and support NullabilityInfoContext with trimming nullability attributes #56475

eerhardt · 2021-07-28T16:19:50Z

This addresses how we are trimming attributes in .NET 6. The problems being solved here are:

A lot of attributes are only trimmed on mono, and not coreclr. Merging the list to be shared, where applicable.
Add a feature switch to turn on/off trimming nullability attributes. When this switch is off, NullabilityInfoContext.Create will throw an exception.
Adding a feature switch to allow for app developers to specify whether they want the aggressive attribute trimming. This allows for Blazor WASM and Maui apps to aggressively trim these attributes, while other app models don't. App developers can flip it either way, giving them the power to decide.

Note: It is probably easiest to review commit-by-commit. The 1st commit is a straight copy from mono to shared, while changes are made in the 2nd commit.

Fix #48217
Fix #55860

@jkotas @MichalStrehovsky @davidwrighton - are there other attributes besides IntrinsicAttribute in this list that shouldn't be removed in coreclr? For example, questionable ones for me were: NonVersionableAttribute, AsyncMethodBuilderAttribute, SkipLocalsInitAttribute, EmbeddedAttribute, NativeIntegerAttribute, or IsUnmanagedAttribute?

runtime/src/mono/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.xml

Lines 4 to 191 in 6789379

    
               <type fullname="System.CLSCompliantAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.ObsoleteAttribute"> 
        
                 <!-- 
        
                   Note that removing this attribute can change runtime behavior. For example, 
        
                   System.Xml.Serialization will behave differently if a ctor is Obsolete. 
        
                   This is low enough risk on wasm to justify the removing the attribute for size 
        
                   savings. The app developer can override this setting to keep all ObsoleteAttributes. 
        
                   --> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Diagnostics.CodeAnalysis --> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Reflection.AssemblyCompanyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyConfigurationAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyCopyrightAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyDefaultAliasAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyDescriptionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyProductAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyTitleAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Runtime.CompilerServices.AsyncMethodBuilderAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerArgumentExpressionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerMemberNameAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerFilePathAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerLineNumberAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerMemberNameAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CompilerGlobalScopeAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.IsReadOnlyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.EnumeratorCancellationAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.ExtensionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.IntrinsicAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.SkipLocalsInitAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.TupleElementNamesAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.Versioning --> 
        
               <type fullname="System.Runtime.Versioning.SupportedOSPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.UnsupportedOSPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.SupportedOSPlatformGuardAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.UnsupportedOSPlatformGuardAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.TargetPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.ComponentModel --> 
        
               <type fullname="System.ComponentModel.EditorBrowsableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- Internal attributes shared as implementation, so they could be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <type fullname="System.Runtime.Versioning.NonVersionableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- Attributes that are allowed to be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.RequiresAssemblyFilesAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.SuppressMessageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.AllowNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DisallowNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MaybeNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MaybeNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullIfNotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MemberNotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MemberNotNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- The following attributes are generated by the compiler, so they could be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Runtime.CompilerServices.IsUnmanagedAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NativeIntegerAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullableContextAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullablePublicOnlyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- Microsoft.CodeAnalysis --> 
        
               <type fullname="Microsoft.CodeAnalysis.EmbeddedAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly>

…eclr - Move IntrinsicAttribute to mono only - Introduce feature switches for NullabilityInfoContext and AggressiveAttributeTrimming - Minor other cleanup

…abilityInfoContext.

ghost · 2021-07-28T16:20:25Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2021-07-28T16:22:27Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

This addresses how we are trimming attributes in .NET 6. The problems being solved here are:

A lot of attributes are only trimmed on mono, and not coreclr. Merging the list to be shared, where applicable.
Add a feature switch to turn on/off trimming nullability attributes. When this switch is off, NullabilityInfoContext.Create will throw an exception.
Adding a feature switch to allow for app developers to specify whether they want the aggressive attribute trimming. This allows for Blazor WASM and Maui apps to aggressively trim these attributes, while other app models don't. App developers can flip it either way, giving them the power to decide.

Note: It is probably easiest to review commit-by-commit. The 1st commit is a straight copy from mono to shared, while changes are made in the 2nd commit.

Fix #48217
Fix #55860

@jkotas @MichalStrehovsky @davidwrighton - are there other attributes besides IntrinsicAttribute in this list that shouldn't be removed in coreclr?

runtime/src/mono/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.xml

Lines 4 to 191 in 6789379

    
               <type fullname="System.CLSCompliantAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.ObsoleteAttribute"> 
        
                 <!-- 
        
                   Note that removing this attribute can change runtime behavior. For example, 
        
                   System.Xml.Serialization will behave differently if a ctor is Obsolete. 
        
                   This is low enough risk on wasm to justify the removing the attribute for size 
        
                   savings. The app developer can override this setting to keep all ObsoleteAttributes. 
        
                   --> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Diagnostics.CodeAnalysis --> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Reflection.AssemblyCompanyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyConfigurationAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyCopyrightAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyDefaultAliasAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyDescriptionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyProductAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyTitleAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Runtime.CompilerServices.AsyncMethodBuilderAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerArgumentExpressionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerMemberNameAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerFilePathAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerLineNumberAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerMemberNameAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CompilerGlobalScopeAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.IsReadOnlyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.EnumeratorCancellationAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.ExtensionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.IntrinsicAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.SkipLocalsInitAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.TupleElementNamesAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.Versioning --> 
        
               <type fullname="System.Runtime.Versioning.SupportedOSPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.UnsupportedOSPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.SupportedOSPlatformGuardAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.UnsupportedOSPlatformGuardAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.TargetPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.ComponentModel --> 
        
               <type fullname="System.ComponentModel.EditorBrowsableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- Internal attributes shared as implementation, so they could be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <type fullname="System.Runtime.Versioning.NonVersionableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- Attributes that are allowed to be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.RequiresAssemblyFilesAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.SuppressMessageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.AllowNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DisallowNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MaybeNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MaybeNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullIfNotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MemberNotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MemberNotNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- The following attributes are generated by the compiler, so they could be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Runtime.CompilerServices.IsUnmanagedAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NativeIntegerAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullableContextAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullablePublicOnlyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- Microsoft.CodeAnalysis --> 
        
               <type fullname="Microsoft.CodeAnalysis.EmbeddedAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly>

Author:	eerhardt
Assignees:	-
Labels:	`area-System.Reflection`, `linkable-framework`
Milestone:	-

jkotas · 2021-07-28T16:37:17Z

docs/workflow/trimming/feature-switches.md

 | MetadataUpdaterSupport | System.Reflection.Metadata.MetadataUpdater.IsSupported | Metadata update related code to be trimmed when set to false |
 | _EnableConsumingManagedCodeFromNativeHosting | System.Runtime.InteropServices.EnableConsumingManagedCodeFromNativeHosting | Getting a managed function from native hosting is disabled when set to false and related functionality can be trimmed. |
+| NullabilityInfoContextSupport | System.Reflection.NullabilityInfoContext.IsSupported | Nullable attributes can be trimmed when set to false |
+| _AggressiveAttributeTrimming | System.AggressiveAttributeTrimming | When set to true, aggressively trims attributes to allow for the most size savings possible, even if it could result in runtime behavior changes |


Why does the name have the _ prefix?

The same reason _EnableConsumingManagedCodeFromNativeHosting has a _ prefix. This isn't intended to be a "public" setting, but only exists for Blazor WASM to trim these attributes, and an escape hatch for developers in case we got it wrong.

buyaa-n

NullabilityInfoContext related changes LGTM

vitek-karas

Looks good - except for the selection of which attributes are dangerous to trim, I'll leave that to more knowledgeable people.

src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs

eerhardt · 2021-07-29T19:13:58Z

Adding a few more coreclr devs to answer this question:

are there other attributes besides IntrinsicAttribute in this list that shouldn't be removed in coreclr? For example, questionable ones for me were: NonVersionableAttribute, AsyncMethodBuilderAttribute, SkipLocalsInitAttribute, EmbeddedAttribute, NativeIntegerAttribute, or IsUnmanagedAttribute?

runtime/src/mono/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.xml

Lines 4 to 191 in 6789379

    
               <type fullname="System.CLSCompliantAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.ObsoleteAttribute"> 
        
                 <!-- 
        
                   Note that removing this attribute can change runtime behavior. For example, 
        
                   System.Xml.Serialization will behave differently if a ctor is Obsolete. 
        
                   This is low enough risk on wasm to justify the removing the attribute for size 
        
                   savings. The app developer can override this setting to keep all ObsoleteAttributes. 
        
                   --> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Diagnostics.CodeAnalysis --> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Reflection.AssemblyCompanyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyConfigurationAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyCopyrightAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyDefaultAliasAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyDescriptionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyProductAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Reflection.AssemblyTitleAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Runtime.CompilerServices.AsyncMethodBuilderAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerArgumentExpressionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerMemberNameAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerFilePathAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerLineNumberAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CallerMemberNameAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.CompilerGlobalScopeAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.IsReadOnlyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.EnumeratorCancellationAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.ExtensionAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.IntrinsicAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.SkipLocalsInitAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.TupleElementNamesAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.Runtime.Versioning --> 
        
               <type fullname="System.Runtime.Versioning.SupportedOSPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.UnsupportedOSPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.SupportedOSPlatformGuardAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.UnsupportedOSPlatformGuardAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.Versioning.TargetPlatformAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- System.ComponentModel --> 
        
               <type fullname="System.ComponentModel.EditorBrowsableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- Internal attributes shared as implementation, so they could be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <type fullname="System.Runtime.Versioning.NonVersionableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- Attributes that are allowed to be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.RequiresAssemblyFilesAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.SuppressMessageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.AllowNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DisallowNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MaybeNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MaybeNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.NotNullIfNotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MemberNotNullAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Diagnostics.CodeAnalysis.MemberNotNullWhenAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly> 
        
             <!-- The following attributes are generated by the compiler, so they could be in any assembly --> 
        
             <assembly fullname="*"> 
        
               <!-- System.Runtime.CompilerServices --> 
        
               <type fullname="System.Runtime.CompilerServices.IsUnmanagedAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NativeIntegerAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullableAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullableContextAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <type fullname="System.Runtime.CompilerServices.NullablePublicOnlyAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
               <!-- Microsoft.CodeAnalysis --> 
        
               <type fullname="Microsoft.CodeAnalysis.EmbeddedAttribute"> 
        
                 <attribute internal="RemoveAttributeInstances" /> 
        
               </type> 
        
             </assembly>

cc @JulieLeeMSFT @AndyAyersMS @tommcdon @agocke

It looks like NonVersionableAttribute is inspected by ReadyToRun, so maybe that one should be moved back to just "mono":

runtime/src/coreclr/vm/methodtable.cpp

Lines 9849 to 9863 in 3ce1168

    
           if (!pMT->GetModule()->IsInCurrentVersionBubble()) 
        
           { 
        
               if (!pMT->IsValueType()) 
        
               { 
        
                   // Eventually, we may respect the non-versionable attribute for reference types too. For now, we are going 
        
                   // to play is safe and ignore it. 
        
                   return FALSE; 
        
               } 
        
               // Valuetypes with non-versionable attribute are candidates for fixed layout. Reject the rest. 
        
               if (pMT->GetModule()->GetMDImport()->GetCustomAttributeByName(pMT->GetCl(), 
        
                       NONVERSIONABLE_TYPE, NULL, NULL) != S_OK) 
        
               { 
        
                   return FALSE; 
        
               }

AndyAyersMS · 2021-07-29T19:21:44Z

I would be leery of trimming any custom attribute that the runtime checks for. I don't know how to effectively enumerate that set, perhaps @jkotas or @davidwrighton can say...

eerhardt · 2021-07-29T20:26:44Z

I would be leery of trimming any custom attribute that the runtime checks for. I don't know how to effectively enumerate that set

Would this be a decent approach?

foreach (Attribute in the above list)
{
   if (coreclr code references the attribute)
   {
      move attribute back to mono-only();
   }
}

AndyAyersMS · 2021-07-29T20:48:42Z

Would this be a decent approach?

Maybe? I don't how easy it actually is to enumerate all the attributes. One place to look is https://github.com/dotnet/runtime/blob/main/src/coreclr/vm/wellknownattributes.h but I suspect it's just convention that attributes are listed there and there may be others that the runtime looks for.

eerhardt · 2021-07-29T20:52:07Z

My thought was just to do a grep for the attribute name in the coreclr folder. If it shows up in a grep, the assumption is that coreclr uses it for something.

davidwrighton · 2021-07-29T21:05:25Z

My look at this list found only NonVersionableAttribute and IntrinsicAttribute as problematic. @eerhardt the idea of using grep seems good tome.

eerhardt · 2021-07-29T23:32:42Z

After searching for each attribute in the list in src/coreclr, here's the hits I found:

IntrinsicAttribute and NonVersionableAttribute should definitely move to mono-only.

NullableAttribute

runtime/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/AttributePresenceFilterNode.cs

Lines 53 to 57 in 57bfe47

    
           // System.Runtime.CompilerServices.NullableAttribute is NEVER added to the table (There are *many* of these, and they provide no useful value to the runtime) 
        
           if (customAttributeTypeNamespace == "System.Runtime.CompilerServices" && customAttributeTypeName == "NullableAttribute") 
        
           { 
        
               continue; 
        
           }

runtime/src/coreclr/zap/zapreadytorun.cpp

Lines 520 to 522 in 57bfe47

    
           // System.Runtime.CompilerServices.NullableAttribute is NEVER added to the table (There are *many* of these, and they provide no useful value to the runtime) 
        
           if ((strcmp(szNamespace, "System.Runtime.CompilerServices") == 0) && (strcmp(szName, "NullableAttribute") == 0)) 
        
               continue;

These places are just filtering out the NullableAttribute. So if we trim it, it won't be in the list anyway. So this should be fine.

TupleElementNamesAttribute is referenced in a code comment here:

runtime/src/coreclr/ilasm/assembler.cpp

Lines 2691 to 2699 in 57bfe47

    
           // We now need to fetch the values of the new GenericParamConstraint tokens 
        
           // that were created by the call to SetGenericParamProps 
        
           // 
        
           // These tokens are the token owners for the custom attributes 
        
           // such as NulableAttribute and TupleElementNamesAttribute 
        
           // 
        
           HCORENUM hEnum = NULL; 
        
           ULONG uCount = 0; 
        
           if (FAILED(m_pImporter->EnumGenericParamConstraints(&hEnum, tkGenericParam, currGPConstraintArr, (ULONG)currNumConstraints, &uCount)))

This is in ilasm, so I'm not sure it "counts" as coreclr runtime

UnconditionalSuppressMessageAttribute

runtime/src/coreclr/tools/Common/Compiler/Logger.cs

Lines 78 to 91 in 57bfe47

    
           internal bool IsWarningSuppressed(int code, MessageOrigin origin) 
        
           { 
        
               if (_suppressedWarnings.Contains(code)) 
        
                   return true; 
        
               IEnumerable<CustomAttributeValue<TypeDesc>> suppressions = null; 
        
               // TODO: Suppressions with different scopes 
        
               if (origin.MemberDefinition is MethodDesc method) 
        
               { 
        
                   var ecmaMethod = method.GetTypicalMethodDefinition() as EcmaMethod; 
        
                   suppressions = ecmaMethod?.GetDecodedCustomAttributes("System.Diagnostics.CodeAnalysis", "UnconditionalSuppressMessageAttribute");

I think this is NativeAOT code, which the trimmer doesn't run before the NativeAOT compiler, so this should be fine. cc @MichalStrehovsky

AssemblyMetadataAttribute

runtime/src/coreclr/inc/corhdr.h

Lines 1875 to 1876 in 57bfe47

    
           #define ASSEMBLY_METADATA_TYPE_W                W("System.Reflection.AssemblyMetadataAttribute") 
        
           #define ASSEMBLY_METADATA_TYPE                  "System.Reflection.AssemblyMetadataAttribute"

This appears to be an unused define. I'll remove it in a separate PR

…l the time on mono WASM

See * dotnet/runtime#55102 * dotnet/runtime#56475

eerhardt added 4 commits July 27, 2021 18:08

Copy ILLink.LinkAttributes from mono to shared.

7f302c8

Update ILLink.LinkAttributes that are now shared between mono and cor…

ddd9f6d

…eclr - Move IntrinsicAttribute to mono only - Introduce feature switches for NullabilityInfoContext and AggressiveAttributeTrimming - Minor other cleanup

Respect the NullabilityInfoContext.IsSupported feature switch in Null…

f5826dd

…abilityInfoContext.

Document new feature switches

e1cabb5

eerhardt requested review from MichalStrehovsky, buyaa-n, marek-safar, sbomer and vitek-karas July 28, 2021 16:19

ghost added area-CoreLib-mono new-api-needs-documentation labels Jul 28, 2021

eerhardt added area-System.Reflection linkable-framework Issues associated with delivering a linker friendly framework and removed area-CoreLib-mono new-api-needs-documentation labels Jul 28, 2021

jkotas reviewed Jul 28, 2021

View reviewed changes

buyaa-n approved these changes Jul 28, 2021

View reviewed changes

vitek-karas approved these changes Jul 28, 2021

View reviewed changes

src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs Show resolved Hide resolved

Add trimming tests for NullabilityInfoContextSupport

860414d

eerhardt added 2 commits July 29, 2021 18:36

Move NonVersionableAttribute to mono-only

4af7f30

Fix Linq tests now that the ExtensionAttribute isn't being trimmed al…

c283933

…l the time on mono WASM

eerhardt mentioned this pull request Jul 30, 2021

Update SDK to support new DI and Attribute feature switches dotnet/sdk#19432

Merged

eerhardt merged commit 577d079 into dotnet:main Jul 30, 2021

eerhardt deleted the ILLinkAttributes branch July 30, 2021 19:07

eerhardt added a commit to dotnet/sdk that referenced this pull request Jul 31, 2021

Update SDK to support new DI and Attribute feature switches (#19432)

e10860e

See * dotnet/runtime#55102 * dotnet/runtime#56475

jaredpar mentioned this pull request Aug 17, 2021

Test failure: System.Security.Cryptography.X509Certificates.Tests.CertificateCreation.CertificateRequestChainTests/CreateChain_Hybrid #25979

Closed

ghost locked as resolved and limited conversation to collaborators Aug 29, 2021

	<type fullname="System.CLSCompliantAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.ObsoleteAttribute">
	<!--
	Note that removing this attribute can change runtime behavior. For example,
	System.Xml.Serialization will behave differently if a ctor is Obsolete.
	This is low enough risk on wasm to justify the removing the attribute for size
	savings. The app developer can override this setting to keep all ObsoleteAttributes.
	-->
	<attribute internal="RemoveAttributeInstances" />
	</type>

	<!-- System.Diagnostics.CodeAnalysis -->
	<type fullname="System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>

	<!-- System.Runtime.CompilerServices -->
	<type fullname="System.Reflection.AssemblyCompanyAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Reflection.AssemblyConfigurationAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Reflection.AssemblyCopyrightAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Reflection.AssemblyDefaultAliasAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Reflection.AssemblyDescriptionAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Reflection.AssemblyProductAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Reflection.AssemblyTitleAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>

	<!-- System.Runtime.CompilerServices -->
	<type fullname="System.Runtime.CompilerServices.AsyncMethodBuilderAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.CallerArgumentExpressionAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.CallerMemberNameAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.CallerFilePathAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.CallerLineNumberAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.CallerMemberNameAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.CompilerGlobalScopeAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.IsReadOnlyAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.EnumeratorCancellationAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.ExtensionAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.IntrinsicAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.SkipLocalsInitAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.TupleElementNamesAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>

	<!-- System.Runtime.Versioning -->
	<type fullname="System.Runtime.Versioning.SupportedOSPlatformAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.Versioning.UnsupportedOSPlatformAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.Versioning.SupportedOSPlatformGuardAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.Versioning.UnsupportedOSPlatformGuardAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.Versioning.TargetPlatformAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>

	<!-- System.ComponentModel -->
	<type fullname="System.ComponentModel.EditorBrowsableAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	</assembly>

	<!-- Internal attributes shared as implementation, so they could be in any assembly -->
	<assembly fullname="*">
	<type fullname="System.Runtime.Versioning.NonVersionableAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	</assembly>

	<!-- Attributes that are allowed to be in any assembly -->
	<assembly fullname="*">
	<type fullname="System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.RequiresAssemblyFilesAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.SuppressMessageAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.AllowNullAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.DisallowNullAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.MaybeNullAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.MaybeNullWhenAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.NotNullAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.NotNullWhenAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.NotNullIfNotNullAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.MemberNotNullAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Diagnostics.CodeAnalysis.MemberNotNullWhenAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	</assembly>

	<!-- The following attributes are generated by the compiler, so they could be in any assembly -->
	<assembly fullname="*">
	<!-- System.Runtime.CompilerServices -->
	<type fullname="System.Runtime.CompilerServices.IsUnmanagedAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.NativeIntegerAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.NullableAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.NullableContextAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	<type fullname="System.Runtime.CompilerServices.NullablePublicOnlyAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>

	<!-- Microsoft.CodeAnalysis -->
	<type fullname="Microsoft.CodeAnalysis.EmbeddedAttribute">
	<attribute internal="RemoveAttributeInstances" />
	</type>
	</assembly>

Move ILLink.LinkAttributes to shared and support NullabilityInfoContext with trimming nullability attributes #56475

Move ILLink.LinkAttributes to shared and support NullabilityInfoContext with trimming nullability attributes #56475

Uh oh!

Conversation

eerhardt commented Jul 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 28, 2021

Uh oh!

ghost commented Jul 28, 2021

Uh oh!

jkotas Jul 28, 2021

Choose a reason for hiding this comment

Uh oh!

eerhardt Jul 28, 2021

Choose a reason for hiding this comment

Uh oh!

buyaa-n left a comment

Choose a reason for hiding this comment

Uh oh!

vitek-karas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eerhardt commented Jul 29, 2021

Uh oh!

AndyAyersMS commented Jul 29, 2021

Uh oh!

eerhardt commented Jul 29, 2021

Uh oh!

AndyAyersMS commented Jul 29, 2021

Uh oh!

eerhardt commented Jul 29, 2021

Uh oh!

davidwrighton commented Jul 29, 2021

Uh oh!

eerhardt commented Jul 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eerhardt commented Jul 28, 2021 •

edited

Loading

eerhardt commented Jul 29, 2021 •

edited

Loading