Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message when publishing logs in Restore internal tools step #56307

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Fix error message when publishing logs in Restore internal tools step #56307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix error message when publishing logs in Restore internal tools step 
In https://dev.azure.com/dnceng/internal/_build/results?buildId=1250178&view=results we hit an issue where the 'Restore internal tools' step failed, but AzDO only highlights the failure in the 'Publish Logs' step because the directory didn't exist.
This happens because the restore step was not passing along the build configuration so it defaults to Debug instead of Release, leading to the log directory we try to publish not existing.
  • Loading branch information
@akoeplinger
akoeplinger committed Jul 26, 2021
commit ca8b98c11fa61d41ae05424e4596c95cf58884b9
1 change: 1 addition & 0 deletions eng/pipelines/common/restore-internal-tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ steps:
- script: $(Build.SourcesDirectory)$(dir)build$(scriptExt)
-ci
-restore
-configuration $(_BuildConfig)
-projects $(Build.SourcesDirectory)/eng/common/internal/Tools.csproj
/bl:$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/RestoreInternal.binlog
/v:normal
Expand Down