Call the jit shutdown logic on crossgen2 shutdown #56187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows the jit shutdown logic to execute reliably on both Windows and Unix
|
@dotnet/crossgen-contrib |
Comment on lines
+84
to
+93
| if (s_jit != IntPtr.Zero) | ||
| { | ||
| return s_jit; | ||
| } | ||
|
|
||
| lock(typeof(JitPointerAccessor)) | ||
| { | ||
| s_jit = getJit(); | ||
| return s_jit; | ||
| } |
There was a problem hiding this comment.
What thread safety guarantees is the lock giving us here? I would expect a double-checked locking pattern at least.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49525