[release/6.0-preview7] Stop building RPMs and Debs during PGO builds #56167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
jeffschwMSFT
approved these changes
Jul 22, 2021
agocke
approved these changes
Jul 22, 2021
agocke
added
Servicing-approved
hoyosjs
approved these changes
Jul 22, 2021
|
The important leg here is "PGO Installer Build and Test coreclr Linux_x64 Release" -- the YAML shouldn't have any impact for other legs. |
|
Ready to merge by someone with permissions |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56113 to release/6.0-preview7
/cc @hoyosjs @agocke
Customer Impact
PGO-instrumented (not optimized) bits were shipped inside the debs and RPMs for P5 and P6. These bits are both much slower than normal (2x minimum perf penalty) and cause
.profdatafiles to be generated in the working directory of any dotnet app.This is caused by a build race, where PGO training pipeline are publishing deb/RPM files with the same name as the standard pipeline. This causes a race where both builds publish bits, and the first one wins. The PGO builds have been winning. The fix is not build debs/RPMs at all for PGO training, which are not needed.
Testing
Manual validation on CI and official that the PGO runs are no longer producing deb/RPMs.
Risk
Very low, small change to YAML.