Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview7] [main] Update dependencies from mono/linker #56106

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 21, 2021

Backport of #55813 to release/6.0-preview7

/cc @agocke @dotnet-maestro[bot]

Customer Impact

Bug fixes in linker. Two primary bugs:

  1. Fix a null-ref in the linker.
  2. Warnings were not appearing in the correct place from DynamicallyAccessedMembers on types. The correct place is also slightly different from where we were reporting warnings before. This requires modifications to the suppressions/attributes in /runtime in order to preserve correct warning behavior for customers.

Testing

Unit tests, testing in dotnet/runtime and linker.

Risk

Low.

dotnet-maestro bot and others added 6 commits July 21, 2021 19:02
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21365.1
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21366.2
Suppress type hierarchy warnings for
DynamicallyAccessedMembers attribute on types that
have members with RequiresUnreferencedCode (or derived
types with such members).
Remove unnecessary local method
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21369.3
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@agocke agocke closed this Jul 21, 2021
@agocke agocke reopened this Jul 21, 2021
@agocke agocke requested review from hoyosjs, sbomer and vitek-karas and removed request for hoyosjs July 22, 2021 00:02
@agocke
Copy link
Member

agocke commented Jul 22, 2021

Closing -- this doesn't meet the bar, so we'll take this in RC.

@agocke agocke closed this Jul 22, 2021
@akoeplinger akoeplinger deleted the backport/pr-55813-to-release/6.0-preview7 branch July 26, 2021 10:15
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants