Avoid race condition in EventSource_UnsuccessfulRequest_LogsStartFailedStop #55913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_UnsuccessfulRequest_LogsStartFailedStop
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThe test is looking at whether an HTTP/X.Y connection has been established. As we were cancelling the request right after the server established the connection (TCP), there is a race condition where the request may fail before constructing the logical HTTP/1.1 connection. Changed the test to wait for the request line to be sent before cancelling the request. Fixes #55906
|
karelz
approved these changes
Jul 19, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is looking at whether an HTTP/X.Y connection has been established. As we were cancelling the request right after the server established the connection (TCP), there is a race condition where the request may fail before constructing the logical HTTP/1.1 connection.
Changed the test to wait for the request line to be sent before cancelling the request.
Fixes #55906