[debugger] Improve debug after hot reload #55869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue Details
|
|
@vargaz could you please review this? |
lambdageek
requested changes
Jul 27, 2021
There was a problem hiding this comment.
Three potential issues:
- The leak in get_docinfo. This is the only one that I'm really worried about for .net6. the debugger can probably call
get_docinfoa lot and without caching we'll leak pretty quickly. - Minor nit: it's probably less error-prone to just store the row number (1-based) instead of an index (0-based) in
MonoDebugInformationEnc. It would be nice to switch. - in the future, I think the row check in
mono_ppdb_get_seq_points_internalwill be wrong. but I don't think it's a problem right now as long as we're only doing updates, not adding new methods.
But overall I think this looks good.
Comment on lines
+506
to
+508
| if (G_UNLIKELY (method_idx - 1 >= table_info_get_rows (methodbody_table))) { | ||
| char *method_name = mono_method_full_name (method, FALSE); | ||
| g_error ("Method idx %d is greater than number of rows (%d) in PPDB MethodDebugInformation table, for method %s in '%s'. Likely a malformed PDB file.", |
There was a problem hiding this comment.
I think right now this is ok since we only have hot reload method body updates - we can't add new methods. But in the future this probably won't work right.
I think this check should be moved up to the (non-EnC) caller, or dropped entirely (or dropped if we have any updates).
…bug_tests * origin/main: (274 commits) Disable test ConnectWithCertificateForDifferentName_Throws (dotnet#56456) Update dependencies from https://github.com/mono/linker build 20210726.2 (dotnet#56374) Cleanup disabled test conditions (dotnet#56381) [mono] Add GC unsafe transition to mono_unhandled_exception (dotnet#56380) don't fail the file extraction when we can't set last write time (dotnet#56370) Properly rebuild optimization data when it changes (dotnet#56397) Make open function calls in coreclr EINTR resilient on macOS (dotnet#56403) Fix dependency from EventLog to TraceSource ref (dotnet#56417) Fix comments in asm with JitDiffableDasm=1 (dotnet#56416) Catch TcpClient ctor exceptions in FtpWebRequest.CreateConnectionAsync (dotnet#56379) Add interop between serializer and DOMs (dotnet#56112) Fix type loader not recognizing overridden method (dotnet#56337) Prevent Segfault in EventPipe on disable (dotnet#56104) Update runtimeconfig.json and deps.json paths when these break past the MAX_PATH threshold (dotnet#56224) Use native allocator instead of pinning when decompressing embedded PDB (dotnet#56336) Specify win-x64 as a valid platform in the microsoft-net-runtime-* workloads for iOS/tvOS/MacCatalyst (dotnet#56311) Fix FailFast message formatting race (dotnet#56388) Try to fix finalizer-based async tests (dotnet#56384) Fix MetricsEventSource tests (dotnet#56382) Remove invalid Castle.DynamicProxy.Internal.AbstractInvocation from ILLink descriptor files (dotnet#56392) ...
lambdageek
reviewed
Jul 28, 2021
…b_lookup_location
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mono_ppdb_lookup_locationfunctionmono_ppdb_get_seq_points_internalfunction to bahavior like the other ones implemented for debug after hot reload.