Handle FileOptions.DeleteOnClose on Unix in SafeFileHandle.Dispose #55153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsFixes #55132
|
stephentoub
force-pushed
the
deletesafehandle
branch
2 times, most recently
from
3192e6b to
3ff0491
Compare
adamsitnik
reviewed
Jul 5, 2021
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/WindowsFileStreamStrategy.cs
Outdated
Show resolved
Hide resolved
Doing so enables cleaning up a bunch of passing around of the file path, while also enabling the path to be fed to more error paths.
stephentoub
force-pushed
the
deletesafehandle
branch
from
3ff0491 to
c6cc987
Compare
adamsitnik
approved these changes
Jul 5, 2021
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, big thanks for fixing it @stephentoub !
stephentoub
force-pushed
the
deletesafehandle
branch
from
c6cc987 to
4232cf4
Compare
stephentoub
added a commit
to stephentoub/runtime
that referenced
this pull request
Jul 6, 2021
…spose (dotnet#55153)" This reverts commit 56b250b.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55132
cc: @dotnet/area-system-io