Skip to content

Add workloads subset for blazor installers #55087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

Conversation

bekir-ozturk
Copy link
Contributor

This PR adds "mono.workloads" subset which generates MSIs and packages that can be used to install blazor workload using dotnet CLI and VS installer.

@ghost
Copy link

ghost commented Jul 2, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@@ -0,0 +1,2 @@
# Building
The workloads project can only be built using .NET Framework msbuild. To build locally, run ```build -project src\workloads\workloads.csproj -msbuildEngine vs```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you copy this from my dotnet/installer PR? That was true before we rebuilt SWIX to support dotnet build and not depend on msbuild.

We should remove this readme

@marek-safar
Copy link
Contributor

Is it intentional to commit nupkg file to the repo?

@ghost
Copy link

ghost commented Jul 2, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR adds "mono.workloads" subset which generates MSIs and packages that can be used to install blazor workload using dotnet CLI and VS installer.

Author: bekir-ozturk
Assignees: joeloff
Labels:

area-Infrastructure-libraries

Milestone: -

@lewing lewing requested review from akoeplinger and steveisok July 7, 2021 21:46
@steveisok steveisok requested a review from directhex July 7, 2021 21:58
@akoeplinger
Copy link
Member

This got merged as part of #55769.

@akoeplinger akoeplinger deleted the dev/bozturk/add-workloads-subset branch August 17, 2021 16:46
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants