Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package native quic library #54992

Merged
merged 9 commits into from
Jul 1, 2021
Merged

package native quic library #54992

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eeda665
package native quic library
wfurt Jul 1, 2021
abb5942
Merge branch 'main' of https://github.com/dotnet/runtime into quicNative
wfurt Jul 1, 2021
33ac7c2
Update System.Net.Quic.csproj
ViktorHofer Jul 1, 2021
db82197
Fix binplacing
ViktorHofer Jul 1, 2021
74a6c09
Merge branch 'quicNative' of https://github.com/wfurt/runtime into qu…
wfurt Jul 1, 2021
0f89cd2
exclude msquic.dll from trimming
wfurt Jul 1, 2021
1817e84
Update src/libraries/System.Net.Quic/src/System.Net.Quic.csproj
wfurt Jul 1, 2021
be39e14
remove local windows override
wfurt Jul 1, 2021
352a474
Merge branch 'quicNative' of https://github.com/wfurt/runtime into qu…
wfurt Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Windows/Interop.Libraries.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ internal static partial class Libraries
internal const string Wtsapi32 = "wtsapi32.dll";
internal const string CompressionNative = "System.IO.Compression.Native";
internal const string GlobalizationNative = "System.Globalization.Native";
internal const string MsQuic = "msquic.dll";
internal const string MsQuic = "MsQuic.Native.dll";
internal const string HostPolicy = "hostpolicy.dll";
internal const string Ucrtbase = "ucrtbase.dll";
}
Expand Down
24 changes: 23 additions & 1 deletion src/libraries/System.Net.Quic/src/System.Net.Quic.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,11 @@
<Compile Include="System\Net\Quic\Implementations\MsQuic\Interop\MsQuicStatusCodes.OSX.cs" />
</ItemGroup>
<!-- Project references -->

<ItemGroup Condition="'$(TargetsWindows)' == 'true'">
<PackageReference Include="System.Net.MsQuic.Transport" PrivateAssets="all" Version="$(SystemNetMsQuicTransportVersion)" />
<PackageReference Include="System.Net.MsQuic.Transport" PrivateAssets="all" GeneratePathProperty="true" Version="$(SystemNetMsQuicTransportVersion)" />
</ItemGroup>

<ItemGroup>
<Reference Include="System.Collections" />
<Reference Include="System.Collections.Concurrent" />
Expand All @@ -76,11 +78,31 @@
<Reference Include="System.Threading" />
<Reference Include="System.Threading.Channels" />
</ItemGroup>

<PropertyGroup>
<BinPlaceNative>true</BinPlaceNative>
<BinPlaceRuntime>false</BinPlaceRuntime>
wfurt marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>

<!-- Support for deploying msquic -->
<ItemGroup Condition="'$(TargetsWindows)' == 'true' and ('$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'x86')">
<Content Include="$(PkgSystem_Net_MsQuic_Transport)\runtimes\win10-$(TargetArchitecture)\native\msquic.dll" Condition="'$(TargetsWindows)' == 'true'">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory>
<TargetPath>MsQuic.Native.dll</TargetPath>
</Content>
<Content Include="$(PkgSystem_Net_MsQuic_Transport)\runtimes\win10-$(TargetArchitecture)\native\msquic.pdb" Condition="'$(TargetsWindows)' == 'true'">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory>
<TargetPath>MsQuic.Native.pdb</TargetPath>
wfurt marked this conversation as resolved.
Show resolved Hide resolved
</Content>
</ItemGroup>

<ItemGroup>
<Content Include="msquic.dll" Condition="Exists('msquic.dll')">
wfurt marked this conversation as resolved.
Show resolved Hide resolved
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory>
<TargetPath>MsQuic.Native.dll</TargetPath>
</Content>
<Content Include="msquic.pdb" Condition="Exists('msquic.pdb')">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
Expand Down