Fix ordinal imports on Windows. #54808
Conversation
Fixes mono/mono#21122 We have existing code for this, but as the test case shows, it doesn't work. It's not really clear how it's supposed to work, since all it does is skip the "#" in the entry point name. GetProcAddress does not interpret numeric strings as ordinals, but it will interpret a pointer address from 1 to 65535 as an ordinal.
monojenkins
requested review from
lambdageek,
lateralusX,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: Issue Details!! This PR is a copy of mono/mono#21123, please do not edit or review it in this repo !! Fixes mono/mono#21122 We have existing code for this, but as the test case shows, it doesn't work. It's not really clear how it's supposed to work, since all it does is skip the "#" in the entry point name. GetProcAddress does not interpret numeric strings as ordinals, but it will interpret a pointer address from 1 to 65535 as an ordinal.
|
ghost
locked as resolved and limited conversation to collaborators
3 participants
!! This PR is a copy of mono/mono#21123, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
Fixes mono/mono#21122
We have existing code for this, but as the test case shows, it doesn't work. It's not really clear how it's supposed to work, since all it does is skip the "#" in the entry point name. GetProcAddress does not interpret numeric strings as ordinals, but it will interpret a pointer address from 1 to 65535 as an ordinal.