Skip to content

Disallow promotion of HVA structs when their fields of TYP_SIMD8 were promoted as plain structs #54694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2021
Merged

Disallow promotion of HVA structs when their fields of TYP_SIMD8 were promoted as plain structs #54694

merged 2 commits into from
Jun 25, 2021

Conversation

echesakov
Copy link
Contributor

Fixes #54647

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 24, 2021
@echesakov echesakov self-assigned this Jun 24, 2021
@echesakov echesakov changed the title Disallow promotion of HVA structs when their fields (TYP_SIMD8 values) were promoted as plain structs Disallow promotion of HVA structs when their fields of TYP_SIMD8 were promoted as plain structs Jun 24, 2021
@echesakov
Disallow promotion of HVA structs if their fields (of TYP_SIMD8) were…
22b2eb5 
… promoted as plain structs in src/coreclr/jit/lclvars.cpp
@echesakov echesakov marked this pull request as ready for review June 24, 2021 23:42
@echesakov
Copy link
Contributor Author

@sandreenko PTAL
cc @dotnet/jit-contrib

sandreenko
sandreenko approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@sandreenko sandreenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echesakov echesakov merged commit e129e32 into dotnet:main Jun 25, 2021
@echesakov echesakov deleted the Runtime_54647 branch June 25, 2021 03:26
@runfoapp runfoapp bot mentioned this pull request Jun 25, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 25, 2021
@echesakov echesakov restored the Runtime_54647 branch March 10, 2022 19:48
@echesakov echesakov deleted the Runtime_54647 branch March 18, 2022 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@sandreenko sandreenko sandreenko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@echesakov echesakov

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion failed genRegMask(regNum) & fullIntArgRegMask()
2 participants
@echesakov @sandreenko