[Mono] Enable runtime tests to run on Android x64 with interpreter #54084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @directhex Issue Details
|
|
I just merged #53752; if you rebase on top of main you should have the changes necessary to run-test-job.yml to make RuntimeVariant accessible to helixpublishwitharcade.proj (and testenvironment.proj). |
|
I'm not sure how the interpreter got disabled on the interpreter lanes. I will be adding a test to make sure that doesn't happen again though. |
|
/azp run runtime,runtime-staging |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
fanyang-mono
force-pushed
the
android_interpreter
branch
from
d114219 to
4dc2791
Compare
|
The failures on windows arm64 were irrelevant to this PR. There are two tracking issues for it https://github.com/dotnet/core-eng/issues/13324 and https://github.com/dotnet/core-eng/issues/13292 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #33381
When working on this PR, I noticed that the mono interpreter lanes were not running with Mono interpreter. This PR also fixes that issue.
This PR also add an option to enable interpreter for Android sample.
2,427 runtime tests were enabled on Android x64 with interpreter. Comparing to Android x64 with JIT, 93 more tests were disabed.