Avoid throwing in ToString() if the process has already exited #53979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @carlossanlop Issue DetailsFixes #1520 Replace #43597 In #43597 was a test fail because we called a process property and initialized internal process cache. So I split the test - one for running process, (2) second for exited process without calling any properties/methods for the test process to avoid the cache initialization.
|
|
I don't know why the test crashes only in runtime-staging. :-( |
terrajobst
added
the
community-contribution
|
@carlossanlop This PR is assigned to you for follow-up/decision before the RC1 snap. |
danmoseley
approved these changes
Jul 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1520
Replace #43597
In #43597 was a test fail because we called a process property and initialized internal process cache. So I split the test - one for running process, (2) second for exited process without calling any properties/methods for the test process to avoid the cache initialization.