Fix memory corruption after free in EventPipe streaming thread. #53886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If streaming thread was aborted with an error it will disable the session. This is not the normal scenario, since most tools will explicit ask to close session, but if there is a network connectivity causing failures to write to stream, session will first be disabled and then it will write NULL into freed memory, causing heap corruption. Fix makes sure we reset streaming_thread before we eventually disable session, making sure it won't write into freed memory.
Member
Author
|
//CC @josalem |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If streaming thread was aborted with an error it will disable the session. This is not the normal scenario, since most tools will explicit ask to close session, but if there is a network connectivity causing failures to write to stream, session will first be disabled and then it will write NULL into freed memory, causing heap corruption.
Fix makes sure we reset streaming_thread before we eventually disable session, making sure it won't write into freed memory.