Support ChaChaPoly1305 on Android if available #52814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis implements ChaChaPoly1305 on Android, if it is available.
|
vcsjones
commented
May 15, 2021
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_cipher.c
Outdated
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_cipher.c
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Algorithms/tests/ChaCha20Poly1305Tests.cs
Outdated
Show resolved
Hide resolved
4 tasks
The CIPHER_HAS_TAG was used to determine if the GCMParameterSpec configuration is needed for variable length tags. While ChaCha20Poly1305 has authentication tags, it does not permit a tag length other than 16 bytes, so there is nothing to configure. This renames the CIPHER_HAS_TAG to be more specific that the cipher supports more than one tag length, and removes it from ChaCha20Poly1305. This simplifies the IV initialization a bit.
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_cipher.c
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Algorithms/tests/ChaCha20Poly1305Tests.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Algorithms/tests/ChaCha20Poly1305Tests.cs
Show resolved
Hide resolved
|
Browser / wasm failure is most likely unrelated. |
bartonjs
reviewed
May 19, 2021
...ecurity.Cryptography.Algorithms/src/System/Security/Cryptography/ChaCha20Poly1305.Android.cs
Show resolved
Hide resolved
bartonjs
reviewed
May 19, 2021
There was a problem hiding this comment.
Looks reasonable to me (modulo one nod and smile). I'm happy so long as @jkoritzinsky is happy with the JNI code.
jkoritzinsky
approved these changes
May 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements ChaChaPoly1305 on Android, if it is available.
Contributes to #52482.
/cc @jkoritzinsky @steveisok