Fix: FileSystemEntry.Attributes property is not correct on Unix - #52235

Merged

carlossanlop merged 17 commits into

dotnet:mainfrom

carlossanlop:FileAttributes

May 8, 2021

Commits on May 4, 2021

Hidden and ReadOnly unit tests.
carlossanlop
committed
739bb27
Unix: Correctly collect ReadOnly and Hidden flags from files and directories.
carlossanlop
committed
3175324
Remove the _initialAttributes field from FileStatus. Directly call _status.GetAttributes from FileSYstemEntry.Attributes since the disk hit is necessary anyway.

carlossanlop
authored and
carlossanlop
committed
8c23640
Address simplication and nullcheck suggestions

carlossanlop
authored and
carlossanlop
committed
6ff6dcc

Commits on May 5, 2021

Defering some more file checking actions to FileStatus. Addressing accessibility of methods/properties. Addressing suggestions.

carlossanlop
authored and
carlossanlop
committed
2423af0

Commits on May 7, 2021

Address feedback: Remove unnecessary asserts but document why. Remove struct initialization. Simplify the order in which Initialize checks for unknown and symlink and add a comment.

carlossanlop
authored and
carlossanlop
committed
7de7c4a
Cache egid and euid, and refresh should reset them

carlossanlop
authored and
carlossanlop
committed
52a7b69
Check IsNameHidden before ensuring cache initialized and checking HasHiddenFlag.

carlossanlop
authored and
carlossanlop
committed
7d9dac0
The ifs inside FileSystemEntry.Initialize has two mutually exclusive conditions: symlink and unknown, so use else if.

carlossanlop
authored and
carlossanlop
committed
e2a05d8
Use entry.IsSymbolicLink directly inside Initialize.

carlossanlop
authored and
carlossanlop
committed
c7d83ed
Remove extra symlink check in FileSystemEnumerator.MoveNext, not needed and could cause unnecessary disk hit.

carlossanlop
authored and
carlossanlop
committed
3b69e81
Remove unused cache checks.

carlossanlop
authored and
carlossanlop
committed
3105cb8
Use HasHiddenFlag as expression body

carlossanlop
authored and
carlossanlop
committed
c40386c
No need to soft retrieve hidden and read-only in FileSystemEntry.Initialize if in AttributesToSkip we are going to retrieve it anyway with a disk hit. Only in the case of DT_UNKNOWN, we will pre-re…

carlossanlop
authored and
carlossanlop
committed
1d96271
Make FileStatus.Initialize inlined in the only place where its called.

carlossanlop
authored and
carlossanlop
committed
7f6cee4

Commits on May 8, 2021

EnsureCacheInitialized bring back order of conditions

carlossanlop
authored and
carlossanlop
committed
c4c3682
Syntax sugar for nullable egid and euid lazy retrieval

carlossanlop
authored and
carlossanlop
committed
817ca95