Add counters to System.Runtime.Caching.MemoryCache #51760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenMolloy
requested review from
CoffeeFlux,
lambdageek,
marek-safar,
thaystg and
vargaz
as code owners
|
Do you need to worry about different instances of the cache ? |
StephenMolloy
force-pushed
the
SRC_Add_Counters
branch
from
34d1f95 to
4c7b16e
Compare
A different Counters EventSource is created for each MemoryCache instance, and they are differentiated by including the name of the cache. This is similar to how MemoryCache publishes per-cache-instance perf counters in NetFx today. |
HongGit
approved these changes
May 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add event counters to MemoryCache.
Full Framework MemoryCache publishes performance counters, but
those went away in the .Net Core port. To help Azure applications
capture performance metrics, we can add these same counters back
to the .Net Core implementation using event counters.