-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Remove harvesting of M.E.DependencyModel #51582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove harvesting of M.E.DependencyModel #51582
Conversation
Tagging subscribers to this area: @eerhardt Issue DetailsThe netstandard1.6 configuration of Microsoft.Extensions.DependencyModel Also dropping the netstandard1.3 asset and the net451 one as the In addition to the harvesting removal, cleaning up the src project which Contributes to #47530
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ViktorHofer !
@ericstj what tells the packaging system that the lib should be supported on netcoreapp1.0? I'm missing some context here. |
IIRC it's looking at the previous package and determining what it supported when deciding what the new package should support. You should be able to repro relatively cheaply locally by building the pkgproj and examining the binlog.
Might be other places to clean that up: #39099 (comment) |
ae9beac
to
8d799bd
Compare
The netstandard1.6 configuration of Microsoft.Extensions.DependencyModel isn't built anymore. Instead the already built matching binary from the latest available package version is redistributed when packaging the DependencyModel library. Also dropping the netstandard1.3 asset and the net451 one as the minimum supported set of platforms are ones that support netstandard2.0. In addition to the harvesting removal, cleaning up the src project which had an unnecessary condition and property set. Contributes to dotnet#47530
8d799bd
to
41e5f17
Compare
Looks like this now has a merge conflict. |
The PR is ready. I'm now using the new packaging hook to exclude frameworks from validation which aren't supported anymore. |
Hello @ViktorHofer! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Network flakiness:
|
The netstandard1.6 configuration of Microsoft.Extensions.DependencyModel
isn't built anymore. Instead the already built matching binary from the
latest available package version is redistributed when packaging the
DependencyModel library.
Also dropping the netstandard1.3 asset and the net451 one as the
minimum supported set of platforms are ones that support netstandard2.0.
In addition to the harvesting removal, cleaning up the src project which
had an unnecessary condition and property set.
Contributes to #47530
cc @terrajobst @ericstj