Skip to content

Remove harvesting of M.E.DependencyModel #51582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2021

Conversation

ViktorHofer
Copy link
Member

The netstandard1.6 configuration of Microsoft.Extensions.DependencyModel
isn't built anymore. Instead the already built matching binary from the
latest available package version is redistributed when packaging the
DependencyModel library.

Also dropping the netstandard1.3 asset and the net451 one as the
minimum supported set of platforms are ones that support netstandard2.0.

In addition to the harvesting removal, cleaning up the src project which
had an unnecessary condition and property set.

Contributes to #47530

cc @terrajobst @ericstj

@ViktorHofer ViktorHofer requested a review from eerhardt April 20, 2021 21:13
@ghost ghost added the area-DependencyModel label Apr 20, 2021
@ghost
Copy link

ghost commented Apr 20, 2021

Tagging subscribers to this area: @eerhardt
See info in area-owners.md if you want to be subscribed.

Issue Details

The netstandard1.6 configuration of Microsoft.Extensions.DependencyModel
isn't built anymore. Instead the already built matching binary from the
latest available package version is redistributed when packaging the
DependencyModel library.

Also dropping the netstandard1.3 asset and the net451 one as the
minimum supported set of platforms are ones that support netstandard2.0.

In addition to the harvesting removal, cleaning up the src project which
had an unnecessary condition and property set.

Contributes to #47530

cc @terrajobst @ericstj

Author: ViktorHofer
Assignees: -
Labels:

area-DependencyModel

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ViktorHofer !

@ViktorHofer
Copy link
Member Author

.packages\microsoft.dotnet.build.tasks.packaging\6.0.0-beta.21216.2\build\Packaging.targets(1119,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Microsoft.Extensions.DependencyModel should be supported on .NETCoreApp,Version=v1.0/win7-x86 but has no compile assets.

@ericstj what tells the packaging system that the lib should be supported on netcoreapp1.0? I'm missing some context here.

@ericstj
Copy link
Member

ericstj commented Apr 20, 2021

IIRC it's looking at the previous package and determining what it supported when deciding what the new package should support. You should be able to repro relatively cheaply locally by building the pkgproj and examining the binlog.

cleaning up the src project which had an unnecessary condition and property set.

Might be other places to clean that up: #39099 (comment)

@ViktorHofer ViktorHofer force-pushed the DependencyModelHarvesting branch from ae9beac to 8d799bd Compare April 21, 2021 08:56
The netstandard1.6 configuration of Microsoft.Extensions.DependencyModel
isn't built anymore. Instead the already built matching binary from the
latest available package version is redistributed when packaging the
DependencyModel library.

Also dropping the netstandard1.3 asset and the net451 one as the
minimum supported set of platforms are ones that support netstandard2.0.

In addition to the harvesting removal, cleaning up the src project which
had an unnecessary condition and property set.

Contributes to dotnet#47530
@ViktorHofer ViktorHofer force-pushed the DependencyModelHarvesting branch from 8d799bd to 41e5f17 Compare April 21, 2021 09:11
@ericstj
Copy link
Member

ericstj commented Apr 21, 2021

Looks like this now has a merge conflict.

@ViktorHofer
Copy link
Member Author

The PR is ready. I'm now using the new packaging hook to exclude frameworks from validation which aren't supported anymore.

@ghost
Copy link

ghost commented Apr 21, 2021

Hello @ViktorHofer!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ViktorHofer
Copy link
Member Author

Network flakiness:

  Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7f8f81b940>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution',)': /simple/certifi/
  Could not find a version that satisfies the requirement certifi==2020.6.20 (from -r /root/helix/scripts/runtime_python_requirements.txt (line 1)) (from versions: )
No matching distribution found for certifi==2020.6.20 (from -r /root/helix/scripts/runtime_python_requirements.txt (line 1))

@ViktorHofer ViktorHofer merged commit cf95928 into dotnet:main Apr 22, 2021
@ViktorHofer ViktorHofer deleted the DependencyModelHarvesting branch April 22, 2021 10:40
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Apr 22, 2021
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Apr 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 22, 2021
@ViktorHofer ViktorHofer removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-DependencyModel breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants