Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release/5.0] - Update Alpine ARM docker image #51345

Merged

Conversation

janvorli
Copy link
Member

Port #51099 to Release/5.0

The Alpine ARM docker image is used for cross compilation. There was a
breaking change in Alpine 3.13 - it uses a new MUSL that has 64 bit
time_t even on 32 bit platforms. Since the official support for Alpine
ARM was not announced yet, it was decided that we will support it only
on Alpine >= 3.13 instead of having to build and distribute two
different
versions of runtime.

This change updates the docker image used to build Alpine ARM runtime to
a new version that uses Alpine 3.13 rootfs. It is also using Ubuntu
16.04 instead of 18.04 as a host to unify it with the one we use to
build for Alpine ARM64.

Customer Impact

This change is needed to switch cross compilation of Alpine ARM runtime to target Alpine 3.13 that will be our minimal supported version for ARM.

Testing

CoreCLR and libraries tests

Risk

Low, we have not announced support of Alpine ARM yet and this change only touches infra to enable proper build / CI testing.

Regression

No

The Alpine ARM docker image is used for cross compilation. There was a
breaking change in Alpine 3.13 - it uses a new MUSL that has 64 bit
time_t even on 32 bit platforms. Since the official support for Alpine
ARM was not announced yet, it was decided that we will support it only
on Alpine >= 3.13 instead of having to build and distribute two
different
versions of runtime.

This change updates the docker image used to build Alpine ARM runtime to
a new version that uses Alpine 3.13 rootfs. It is also using Ubuntu
16.04 instead of 18.04 as a host to unify it with the one we use to
build for Alpine ARM64.
@janvorli janvorli added Servicing-consider Issue for next servicing release review area-Infrastructure-coreclr labels Apr 15, 2021
@janvorli janvorli added this to the 5.0.x milestone Apr 15, 2021
@janvorli janvorli requested a review from hoyosjs April 15, 2021 21:44
@janvorli janvorli self-assigned this Apr 15, 2021
@ghost
Copy link

ghost commented Apr 15, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Port #51099 to Release/5.0

The Alpine ARM docker image is used for cross compilation. There was a
breaking change in Alpine 3.13 - it uses a new MUSL that has 64 bit
time_t even on 32 bit platforms. Since the official support for Alpine
ARM was not announced yet, it was decided that we will support it only
on Alpine >= 3.13 instead of having to build and distribute two
different
versions of runtime.

This change updates the docker image used to build Alpine ARM runtime to
a new version that uses Alpine 3.13 rootfs. It is also using Ubuntu
16.04 instead of 18.04 as a host to unify it with the one we use to
build for Alpine ARM64.

Customer Impact

This change is needed to switch cross compilation of Alpine ARM runtime to target Alpine 3.13 that will be our minimal supported version for ARM.

Testing

CoreCLR and libraries tests

Risk

Low, we have not announced support of Alpine ARM yet and this change only touches infra to enable proper build / CI testing.

Regression

No

Author: janvorli
Assignees: janvorli
Labels:

Servicing-consider, area-Infrastructure-coreclr

Milestone: 5.0.x

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This is an infra only change, but I will take it as part of the consideration of the other Alpine 3.13 change.

@jeffschwMSFT
Copy link
Member

@leecow we discussed this and I believe we approved it. Though it looks like we did not fully mark this issue as approved.

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 21, 2021
@jeffschwMSFT jeffschwMSFT modified the milestones: 5.0.x, 5.0.7 Apr 21, 2021
@Anipik Anipik merged commit 49f4fb8 into dotnet:release/5.0 May 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants