Skip to content

Race condition in Mock reference tracker runtime with GC. #50804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Race condition in Mock reference tracker runtime with GC. #50804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/tests/Interop/COM/ComWrappers/MockReferenceTrackerRuntime/ReferenceTrackerRuntime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include <ComHelpers.h>
#include <unordered_map>
#include <list>
#include <mutex>
#include <inspectable.h>

namespace API
Expand Down Expand Up @@ -315,12 +316,16 @@ namespace
class TrackerRuntimeManagerImpl : public API::IReferenceTrackerManager
{
ComSmartPtr<API::IReferenceTrackerHost> _runtimeServices;
std::mutex _objectsLock;
std::list<ComSmartPtr<TrackerObject>> _objects;

public:
ITrackerObject* RecordObject(_In_ TrackerObject* obj, _Outptr_ IUnknown** inner)
{
_objects.push_back(ComSmartPtr<TrackerObject>{ obj });
{
std::lock_guard<std::mutex> guard{ _objectsLock };
_objects.push_back(ComSmartPtr<TrackerObject>{ obj });
}

if (_runtimeServices != nullptr)
_runtimeServices->AddMemoryPressure(sizeof(TrackerObject));
Expand All @@ -337,12 +342,17 @@ namespace

void ReleaseObjects()
{
std::list<ComSmartPtr<TrackerObject>> objectsLocal;
{
std::lock_guard<std::mutex> guard{ _objectsLock };
objectsLocal = std::move(_objects);
}

// Unpeg all instances
for (auto& i : _objects)
for (auto& i : objectsLocal)
(void)i->DisconnectFromReferenceTrackerRuntime();

size_t count = _objects.size();
_objects.clear();
size_t count = objectsLocal.size();
if (_runtimeServices != nullptr)
_runtimeServices->RemoveMemoryPressure(sizeof(TrackerObject) * count);
}
Expand All @@ -358,6 +368,8 @@ namespace
public: // IReferenceTrackerManager
STDMETHOD(ReferenceTrackingStarted)()
{
std::lock_guard<std::mutex> guard{ _objectsLock };

// Unpeg all instances
for (auto& i : _objects)
i->TogglePeg(/* should peg */ false);
Expand All @@ -367,6 +379,8 @@ namespace

STDMETHOD(FindTrackerTargetsCompleted)(_In_ BOOL bWalkFailed)
{
std::lock_guard<std::mutex> guard{ _objectsLock };

// Verify and ensure all connected types are pegged
for (auto& i : _objects)
i->TogglePeg(/* should peg */ true);
Expand Down