Skip to content

Disable test VerifyInMemoryDirectoryInfo_IsNotEmpty #50660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

carlossanlop
Copy link
Contributor

Fixes #50648

This is to unblock people seeing the CI failure.

The actual bug is here, and will need a deeper investigation: #50648 (comment)

@ghost
Copy link

ghost commented Apr 2, 2021

Tagging subscribers to this area: @maryamariyan, @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50648

This is to unblock people seeing the CI failure.

The actual bug is here, and will need a deeper investigation: #50648 (comment)

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Extensions-FileSystem

Milestone: -

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlossanlop
Copy link
Contributor Author

carlossanlop commented Apr 2, 2021

I can now see two relevant CI legs being queued for this PR:

I mention them because it seems the original PR that introduced this unit test did not run it in arm64, hence why the failure was not detected until later.

@ericstj
Copy link
Member

ericstj commented Apr 2, 2021

I believe those are builds but not tests. I saw the same run in the original PR but the tests were not executed. It's understood why that happens. There are other workflows that are not PR validation, however, that do expect libraries tests to run on arm64 (Bruce's JIT stress runs I think).

@carlossanlop
Copy link
Contributor Author

Ah ok, good to know. Thanks.

@BruceForstall
Copy link
Contributor

Exactly: there are 3 JIT stress pipelines that run libraries tests in many stress variations against a Checked coreclr on all platforms:

https://dev.azure.com/dnceng/public/_build?definitionId=833
https://dev.azure.com/dnceng/public/_build?definitionId=668
https://dev.azure.com/dnceng/public/_build?definitionId=669

Note also that these are the only runs (I believe) that run the libraries tests with the JIT in optimization mode (namely, tiered compilation disabled: COMPlus_TieredCompilation=0). That has been a separate worry for a long time.

@carlossanlop carlossanlop merged commit 5265305 into dotnet:main Apr 2, 2021
@carlossanlop carlossanlop deleted the Disable50648 branch April 2, 2021 23:34
@ghost ghost locked as resolved and limited conversation to collaborators May 3, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InMemoryDirectoryInfo is unexpectedly dependent on working directory due to its use of GetFullPath.
5 participants