Include Mono in the name of all Mono runtime packs #50327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously only used this naming on platforms that already had coreclr as an option. Using Mono in the name all the time will make what runtime you're dealing with less ambiguous.
ghost
added
the
steveisok
requested review from
jkoritzinsky,
akoeplinger,
directhex,
lewing,
radical,
naricc,
rolfbjarne and
jonathanpeppers
|
@DrewScoggins When this is merged you will need to update anything in perf that looks for the runtime pack by name. |
akoeplinger
approved these changes
Apr 9, 2021
|
Just for clarity can we have a before and after list for the affected package names? |
Yeah, I'll run an official build before I merge and get the list from that. |
|
The following runtime packs have Mono as part of their name where they did not before: Microsoft.NETCore.App.Runtime.Mono.(os)-(arch) |
|
Successful official build https://dev.azure.com/dnceng/internal/_build/results?buildId=1080159&view=results |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only used this naming on platforms that already had coreclr as an option. Using Mono in the name all the time will make what runtime you're dealing with less ambiguous.
Fixes #49718