Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocate string literals on frozen segments #49576

Merged
merged 69 commits into from
Sep 13, 2022
Merged

Allocate string literals on frozen segments #49576

merged 69 commits into from
Sep 13, 2022

Commits on Jul 3, 2021

  1. Naive implementation of FrozenObjectHeap

    @EgorBo
    EgorBo committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    166ccfe View commit details
    Browse the repository at this point in the history

  2. Add RegisterFrozenSegment

    @EgorBo
    EgorBo committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    1cb0927 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2021

  1. Clean up

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    d2b9cbf View commit details
    Browse the repository at this point in the history

  2. Add #include "common.h"

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    641365a View commit details
    Browse the repository at this point in the history

  3. Fix build error

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    33a126b View commit details
    Browse the repository at this point in the history

  4. Fix build

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    bb1b835 View commit details
    Browse the repository at this point in the history

  5. Add lock

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    2ef204a View commit details
    Browse the repository at this point in the history

  6. Clean up

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    a84a6ee View commit details
    Browse the repository at this point in the history

  7. init memory on first allocation

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    142295a View commit details
    Browse the repository at this point in the history

  8. Clean up

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    a446dd6 View commit details
    Browse the repository at this point in the history

  9. revert changes in emitxarch.cpp

    @EgorBo
    EgorBo committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    41665c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite… 

    …rals

# Conflicts:
#	src/coreclr/jit/codegenarmarch.cpp
#	src/coreclr/jit/codegenxarch.cpp
#	src/coreclr/vm/appdomain.hpp
    @EgorBo
    EgorBo committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    66d6106 View commit details
    Browse the repository at this point in the history

  2. Update branch, fix asserts

    @EgorBo
    EgorBo committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    67f32a7 View commit details
    Browse the repository at this point in the history

  3. fix release build

    @EgorBo
    EgorBo committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    9ecf7d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Ignore collectible assemblies, fix build

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    45a454a View commit details
    Browse the repository at this point in the history

  2. Fix failing tests, address feedback

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    1d0a710 View commit details
    Browse the repository at this point in the history

  3. Rename bAppDomainWontUnload to bIsCollectible

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    201565e View commit details
    Browse the repository at this point in the history

  4. Address feedback

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    c7dad85 View commit details
    Browse the repository at this point in the history

  5. Clean up

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    4202d9f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:dotnet/runtime into poh2

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    69ab9d2 View commit details
    Browse the repository at this point in the history

  7. Fix assert

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    a144453 View commit details
    Browse the repository at this point in the history

  8. Fix more asserts not expecting TYP_REF constants being non zero

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    2571c9c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' of github.com:dotnet/runtime into poh2

    @EgorBo
    EgorBo committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    286f8ab View commit details
    Browse the repository at this point in the history

  10. Test gc fix

    @EgorBo
    EgorBo committed Jul 29, 2022
    1 Configuration menu
    Copy the full SHA
    28e0331 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2022

  1. move check to IsEphemeral

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    6625759 View commit details
    Browse the repository at this point in the history

  2. Test commit (do I need to update "ibAllocated"?)

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    89df356 View commit details
    Browse the repository at this point in the history

  3. Implement commit-on-demand

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    3cb98e9 View commit details
    Browse the repository at this point in the history

  4. Clean up

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    c6df9ed View commit details
    Browse the repository at this point in the history

  5. bump FOH_COMMIT_PAGES

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    f50b4b9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:dotnet/runtime into poh2

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    2b55835 View commit details
    Browse the repository at this point in the history

  7. Address feedback, clean up

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    6ea2a50 View commit details
    Browse the repository at this point in the history

  8. Fix build

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    15ca880 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' of github.com:dotnet/runtime into poh2

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    193676e View commit details
    Browse the repository at this point in the history

  10. Unix's ClrVirtualAlloc seems to be non-aligned

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    9198043 View commit details
    Browse the repository at this point in the history

  11. Oops, fix red CI

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    7c98ef2 View commit details
    Browse the repository at this point in the history

  12. Multiple frozen segments

    @EgorBo
    EgorBo committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    af6e445 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into poh2 

    # Conflicts:
#	src/coreclr/gc/gc.cpp
    @EgorBo
    EgorBo committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    2183c2f View commit details
    Browse the repository at this point in the history

  2. Clean up

    @EgorBo
    EgorBo committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    4ef34dd View commit details
    Browse the repository at this point in the history

  3. fix typo

    @EgorBo
    EgorBo committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    722eb82 View commit details
    Browse the repository at this point in the history

  4. Fix assert in assertionprop.cpp

    @EgorBo
    EgorBo committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    0ae890a View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Address feedback

    @EgorBo
    EgorBo committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    e59d27a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite… 

    …rals
    @EgorBo
    EgorBo committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    90feb96 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite… 

    …rals

# Conflicts:
#	src/coreclr/inc/crsttypes.h
    @EgorBo
    EgorBo committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    ce3e19e View commit details
    Browse the repository at this point in the history

  2. Address feedback

    @EgorBo
    EgorBo committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    b6fae80 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite… 

    …rals
    @EgorBo
    EgorBo committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    32cb338 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Address feedback

    @EgorBo
    EgorBo committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d20cc47 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Fix potential issues

    @EgorBo
    EgorBo committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    31b5fdc View commit details
    Browse the repository at this point in the history

  2. Fix potential issues

    @EgorBo
    EgorBo committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    1b1ab4c View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite… 

    …rals
    @EgorBo
    EgorBo committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    ed8ed7b View commit details
    Browse the repository at this point in the history

  2. Address feedback

    @EgorBo
    EgorBo committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    88ad320 View commit details
    Browse the repository at this point in the history

  3. Address feedback

    @EgorBo
    EgorBo committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    943a235 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Check if this fixes all asserts

    @EgorBo
    EgorBo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    a3bfc8c View commit details
    Browse the repository at this point in the history

  2. Handle string.Empty (it used to be ignored)

    @EgorBo
    EgorBo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1be12c5 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    5c2a222 View commit details
    Browse the repository at this point in the history

  4. Address feedback

    @EgorBo
    EgorBo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    19d1734 View commit details
    Browse the repository at this point in the history

  5. Address feedback

    @EgorBo
    EgorBo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4762bcc View commit details
    Browse the repository at this point in the history

  6. Update src/coreclr/vm/stringliteralmap.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2e03cc2 View commit details
    Browse the repository at this point in the history

  7. Update src/coreclr/vm/stringliteralmap.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2f00f71 View commit details
    Browse the repository at this point in the history

  8. fix compilation errors

    @EgorBo
    EgorBo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    ddfbf73 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite… 

    …rals
    @EgorBo
    EgorBo committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    598b9c8 View commit details
    Browse the repository at this point in the history

  2. Address Jan's feedback

    @EgorBo
    EgorBo committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    802106e View commit details
    Browse the repository at this point in the history

  3. Update src/coreclr/jit/gentree.cpp 

    Co-authored-by: Andy Ayers <andya@microsoft.com>
    @EgorBo @AndyAyersMS
    EgorBo and AndyAyersMS authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bfe96e7 View commit details
    Browse the repository at this point in the history

  4. Update gentree.cpp

    @EgorBo
    EgorBo authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2e10c9c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into poh-string-lite… 

    …rals
    @EgorBo
    EgorBo committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3415dc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Address Maoni's feedback: 

    1) Rename FrozenObjectHeap to FrozenObjectSegment since it represents a single segment
2) Remove unnecessary config knobs and leave only turn off/on one
    @EgorBo
    EgorBo committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    bac0389 View commit details
    Browse the repository at this point in the history

  2. heap -> segment in comments

    @EgorBo
    EgorBo committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    01b5731 View commit details
    Browse the repository at this point in the history

  3. Update src/coreclr/vm/frozenobjectheap.h 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    8d139c9 View commit details
    Browse the repository at this point in the history

  4. Address Jan's feedback around m_Crst creation

    @EgorBo
    EgorBo committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b6deb3c View commit details
    Browse the repository at this point in the history

  5. Fix order of initialization

    @EgorBo
    EgorBo committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    1ba9d97 View commit details
    Browse the repository at this point in the history