Fix the mono cmake build to work without mono.proj. #47913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
CoffeeFlux
approved these changes
Feb 5, 2021
akoeplinger
reviewed
Feb 5, 2021
| "#define RuntimeProductMinorVersion 0\n" | ||
| "#define RuntimeProductPatchVersion 0\n" | ||
| ) | ||
| endif() |
Member
There was a problem hiding this comment.
instead of writing to these unused header files and reading them back I'd rather do
if (NOT EXISTS "${CMAKE_CURRENT_BINARY_DIR}/_version.h" AND NOT EXISTS "${CMAKE_CURRENT_BINARY_DIR}/runtime_version.h")
set(VERSION "\"42.42.42.0\"")
set(FULL_VERSION "42.42.42.42424")
else()
... existing code ...
endif()
Contributor
Author
There was a problem hiding this comment.
runtime-version.h is included in some eventpipe files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.