Minor cleanup for Rfc2898DeriveBytes #47483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _password field is not needed since CryptDeriveKey was not ported from the Desktop framework. Removing the field also allows removing a defensive copy and clearing it during disposal.
ghost
added
the
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq Issue DetailsThe Removing the field also allows removing a defensive copy and clearing it during disposal.
|
GrabYourPitchforks
approved these changes
Jan 26, 2021
...stem.Security.Cryptography.Algorithms/src/System/Security/Cryptography/Rfc2898DeriveBytes.cs
Show resolved
Hide resolved
bartonjs
approved these changes
Jan 26, 2021
stephentoub
approved these changes
Jan 26, 2021
bartonjs
approved these changes
Jan 26, 2021
...stem.Security.Cryptography.Algorithms/src/System/Security/Cryptography/Rfc2898DeriveBytes.cs
Show resolved
Hide resolved
bartonjs
approved these changes
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_passwordfield is not needed sinceCryptDeriveKeywas not ported from the Desktop framework and that was the only API that needed it.Removing the field also allows removing a defensive copy and clearing it during disposal.