Get rid of StreamWriter usage in HTTP loopback server and fix HTTP/1.1 loopback implementation of SendResponseBodyAsync #47364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is not needed, and causes some confusion in places in the tests. @wfurt @dotnet/ncl
|
geoffkizer
changed the title
stephentoub
reviewed
Jan 25, 2021
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Connect.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 25, 2021
wfurt
approved these changes
Jan 25, 2021
|
BTW I don't see past failures of SendAsync_WithZeroLengthHeaderName_Throws. So it may be related to the PR |
Yeah I think this PR expose a timing-related exception here. Pushed a fix for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StreamWriter usage is not needed, and the incorrect implementation of SendResponseBodyAsync is problematic.
@wfurt @dotnet/ncl