Add android AOT/PInvoke functional test #47167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
@MaximLipnin You'll need to rebase against master in order for the aot compiler to warn as opposed to error. |
MaximLipnin
force-pushed
the
add-android-aot-func-test
branch
2 times, most recently
from
3ea1f41 to
6452aa1
Compare
mdh1418
reviewed
Jan 21, 2021
MaximLipnin
force-pushed
the
add-android-aot-func-test
branch
from
6452aa1 to
31787d0
Compare
|
Tagging subscribers to this area: @directhex Issue Details
|
MaximLipnin
force-pushed
the
add-android-aot-func-test
branch
3 times, most recently
from
6731bac to
9e4db46
Compare
MaximLipnin
requested review from
EgorBo,
marek-safar and
vargaz
as code owners
MaximLipnin
force-pushed
the
add-android-aot-func-test
branch
from
9e4db46 to
41a02db
Compare
MaximLipnin
force-pushed
the
add-android-aot-func-test
branch
2 times, most recently
from
6930d1b to
243506d
Compare
MaximLipnin
force-pushed
the
add-android-aot-func-test
branch
2 times, most recently
from
659d7e3 to
02dd6d1
Compare
MaximLipnin
force-pushed
the
add-android-aot-func-test
branch
from
c3aa602 to
f083485
Compare
steveisok
approved these changes
Feb 21, 2021
There was a problem hiding this comment.
@akoeplinger You mentioned something needed to be done to the AOT task beyond this PR. If that still applies, can you explain?
MaximLipnin
force-pushed
the
add-android-aot-func-test
branch
from
f083485 to
6f1f7b0
Compare
MaximLipnin
changed the title
|
@akoeplinger Please review and if it looks good, merge. |
akoeplinger
approved these changes
Mar 2, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./build.sh mono+libs -os Android -arch x64 -c Release./dotnet.sh build /t:Test src/tests/FunctionalTests/Android/Device_Emulator/AOT /p:TargetOS=Android /p:TargetArchitecture=x64 /p:Configuration=Release./dotnet.sh build /t:Test src/tests/FunctionalTests/Android/Device_Emulator/PInvoke /p:TargetOS=Android /p:TargetArchitecture=x64 /p:Configuration=Release